Verilator lint fixes #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marnovandermaas
force-pushed
the
verilator_lint_fixes
branch
from
553720c
to
017ac05
Compare
This comment was marked as outdated.
This comment was marked as outdated.
marnovandermaas
force-pushed
the
verilator_lint_fixes
branch
from
017ac05
to
663dfcc
Compare
|
@microsoft-github-policy-service agree company="lowRISC" |
This comment was marked as outdated.
This comment was marked as outdated.
|
Thanks - sorry for the delayed response and I will look into it. I haven't been ignoring this but just a little swamped recently. We may have to do a manual merge this time since there are a few more updates on my side as well. |
This comment was marked as resolved.
This comment was marked as resolved.
marnovandermaas
force-pushed
the
verilator_lint_fixes
branch
2 times, most recently
from
22e94c2
to
a038a80
Compare
Verilator 4.210 does not support this type of array assigment so I've split it up to improve compatibility.
This solves Verilator width lint warnings.
marnovandermaas
force-pushed
the
verilator_lint_fixes
branch
from
a038a80
to
3290c74
Compare
|
I've removed two commits from this PR because of recent changes and to revert a change in behavior. This should now be ready for review. |
kliuMsft
approved these changes
Feb 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes various problems picked up by browsing Verilator lint warnings. Please have a look at the individual commit messages for details of why the changes were made.