Fix issues in the Feb update #410

aaronbell · 2021-02-13T03:23:12Z

Summary of the Pull Request

A small set of fixes that resolves a couple of new bugs introduced in the latest version, plus other fixes I have been working on.

PR Checklist

Closes Misaligned arrows when creating infinite arrow using equals sign #406 - updated anchor type to lock with the other equals-related ligatures
Closes Wrong design for U+2262 #408 - corrected component used for glyph to align with Unicode
Closes locl features that swap 2 glyphs for 1 glyph #412 - updated locl features removing iacute_j ligature and Catalan substitution
Closes Small gaps are visible in new arrow ligatures in the Konsole terminal emulator #414 - increased overlaps of middle glyph for arrow ligatures
Closes Ḵ, Ḻ, Ṉ, Ṯ, ḵ, ḻ, ṉ have a macron below not an underline #415 - reduces width of macronbelow
Closes Documentation: Update IntelliJ IDEA Setup Instructions #416 - rolls back name ID 4 modification as JetBrains cannot process it correctly
Closes Remove MVAR table #428 - rolls back variation of the underline to prevent MVAR table generation

Detailed Description of the Pull Request / Additional comments

Full changelist:

Repositioned tilde in related ligatures. Previously it was higher than the standard one.
Added missing vietnamese anchors on acute and grave (futureproofing).
Corrected / made consistent greater & less positioning in </> and <$> related ligatures.
Otherwise reviewed hinting

Decreased Bold weight, added anchors to lowercase Greek, updated GDEF feature builder. Added font linking to STAT.

Reduced weight of bold extreme for better alignment with Regular. Resolved some introduced bugs in hinting and glyph widths.

…Terminal" This reverts commit 91ce4ee.

This reverts commit 25dc61a.

Updating code for the build process and adding in a separate hinting file for the PL glyphs.

Updates build script to include madig's modifications, plus adds static TTF export and autohinting using ttfautohint (if available). Also updated / renamed the Nerdfonts PL file.

- Adjusted box drawing characters for better alignment to the letters - Added anchors to all alphabetic characters (also brevecomb-cy which was missing them) - added a fi and fl ligature (and decompose them so they never show up :) ) - improved weight of horncomb (lowercase) in bold

Changing contour order for Extralight to resolve interpolation error

1) Added support for Salishan language groups 2) Remastered mark positioning for glyphs with 2 diacritics (needed for Salishan) 3) Rebuild Build Script to simplify code 4) Fixed minor other hinting issues 5) Fixed RVRN substitutions for heavy weight

Also it wants to update the hyphen glyph, but I don't see any specific changes.

Re-adding the static folder

- updates macronbelow design - increases overlap on middle positions for infinite arrows - remove iacute_j ligated forms, added jacute forms - removed Catalan locl substitutions - updated a couple of hints

aaronbell · 2021-02-17T00:24:36Z

Adding a few more updates :)

DHowett · 2021-02-24T00:45:21Z

@aaronbell this good for release soon? I'm happy to review/sign off and tag it 2102.23 if so :)

aaronbell · 2021-02-24T00:59:43Z

@DHowett the only other thing that might be worth doing is the postscript name issue I emailed you about a little while ago. Did you have thoughts on that?

Forgot to set this back to 1200! Oops ❌

- reverted nameID 4 modification - disabled underline variation as MVAR not properly supported.

aaronbell · 2021-02-24T21:40:12Z

@DHowett I've submitted another couple of small fixes to resolve the postscript issue and prevent MVAR table generation. Should be good to go.

DHowett · 2021-02-25T03:51:19Z

Thanks! I'll build this into the next version of Terminal. Unfortunately, I missed the boat for this one by just a hair, so I'll hold back just a little while to avoid breaking people.

I have GOT to get Cascadia out of our package. Good lord.

aaronbell · 2021-02-25T04:01:30Z

@DHowett It'd probably be good—I think you can set up the packages such that the Windows Terminal one will automatically download a "Cascadia Code" one.

That way we could also put the PL fonts in too, no? Then folks wouldn't have to download them separately!

Ben Kiel mentioned that there are edge cases in Dutch where one would not want to have a jacute following an iacute, and that safer behavior is to only swap in cases where the j is followed by an acutecomb—a use case already covered by ccmp. I will likely add back a accented form of the ij and IJ glyphs, but that can be at a later date :)

DHowett · 2021-02-25T20:01:45Z

@aaronbell whoops, ufolint got real mad about this. I also fixed the PR trigger so it would fail future PRs for linting errors.

2021-02-25T20:00:28.8261060Z Test result that led to failure:
2021-02-25T20:00:28.8365140Z [FAIL] sources/CascadiaCode-Bold.ufo/glyphs.public.background contains rogue files not listed in contents.plist: gheupturn-cy.glif, asciitilde_equal.liga.glif, less_less_equal_start.seq.glif, quotedblbase.glif, g.glif, less_less_equal_middle.seq.glif, parenleft_asterisk.liga.glif, ka-cy.glif, kaiS_ymbol.glif, A_lpha-latin.glif, idotless.glif, dcaron.alt.glif, G_stroke.glif, N_hookleft.glif, greater_greater_hyphen_middle.seq.glif, kappa.glif, numbersign_underscore_parenleft.liga.glif, greater_greater_equal_start.seq.glif, quoteright.glif, nine.glif, quotesinglbase.glif, d.glif, greater_greater_equal_middle.seq.glif, quoteleft.glif, p.glif, greater.center.glif, numbersign_middle.seq.glif, less_less_hyphen_middle.seq.glif, rho.glif, less_less_hyphen_start.seq.glif, greater_greater_hyphen_end.seq.glif, six.glif, onehalf.glif, K_aiS_ymbol.glif, nhookleft.glif, asterisk_parenright.liga.glif, greater_greater_equal_end.seq.glif, less_less_hyphen_end.seq.glif, greater.alt.glif, less_less_equal_end.seq.glif, notedbl-musical.glif, kadescender-cy.glif, degree.glif, dashdownA_rrow.glif, integraltp.glif, integralbt.glif

This seems like a very much not good thing? Are these dead old files that got moved and replaced? I noticed some things got moved out of background into public but didn't know enough to ask.

DHowett · 2021-02-25T20:04:59Z

I suspect that the files in the background/ directory are outdated and should have been deleted because in the previous update you moved them into the non-background one?

aaronbell · 2021-02-25T20:06:05Z

Yeah, all those files (and the folders themselves I think) can just be deleted. No background files necessary!

DHowett · 2021-02-25T20:06:55Z

Whoa, none? The background contents file still refers to one thing: macronbelowcomb.

aaronbell · 2021-02-25T20:09:03Z

The background files have no impact on the font output. They're just there as extra cruft from my development work. I should really just delete them all on conversion to UFO.

DHowett · 2021-02-25T20:10:02Z

Mind doing that in a PR? I'm strapped into meetings almost all day ☹️

aaronbell · 2021-02-25T20:15:04Z

Oh... I merged the fix in :)

DHowett · 2021-02-25T20:16:40Z

huh, it notified me that your PR was closed (without merging)

aaronbell · 2021-02-25T20:17:43Z

Oh yeah, I PR'd the wrong thing, so closed it. Ended up just merging in an update directly. :x

aaronbell · 2021-02-25T20:18:21Z

(d4fac8b)

DHowett · 2021-02-25T20:23:38Z

☹️

2021-02-25T20:23:08.8372820Z ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2021-02-25T20:23:08.8418550Z sources/CascadiaCode-Bold.ufo
2021-02-25T20:23:08.8519700Z ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2021-02-25T20:23:08.8621680Z  
2021-02-25T20:23:08.8723270Z [UFO directory] ....... 
2021-02-25T20:23:08.8819450Z    Found UFO v3
2021-02-25T20:23:08.8841710Z    Detected glyphs directories: 
2021-02-25T20:23:08.8843730Z      -- glyphs . 
2021-02-25T20:23:08.8845470Z      -- glyphs.public.background F
2021-02-25T20:23:08.8846400Z 
2021-02-25T20:23:08.8847740Z =============================================================================
2021-02-25T20:23:08.8849980Z sources/CascadiaCode-Bold.ufo failed ufolint testing! Exit with status code 1
2021-02-25T20:23:08.8851490Z =============================================================================
2021-02-25T20:23:08.8952800Z  
2021-02-25T20:23:08.9017690Z Test result that led to failure:
2021-02-25T20:23:08.9119990Z [FAIL] Unable to find the UFO directory 'glyphs.public.background' defined in layercontents.plist
2021-02-25T20:23:08.9219570Z

aaronbell · 2021-02-25T20:24:41Z

Well that serves me right.

aaronbell · 2021-02-25T20:27:25Z

OK. updated again. Double-checked that it builds. :)

aaronbell and others added 30 commits June 29, 2020 17:15

Merge remote-tracking branch 'upstream/master'

8dcda47

Merge remote-tracking branch 'upstream/master'

b51240f

General improvements

c63fcfc

Decreased Bold weight, added anchors to lowercase Greek, updated GDEF feature builder. Added font linking to STAT.

Unboldening!

d0b2e14

Reduced weight of bold extreme for better alignment with Regular. Resolved some introduced bugs in hinting and glyph widths.

Updating the PL character heights to align better in Windows Terminal

91ce4ee

Update build.py

25dc61a

Revert "Updating the PL character heights to align better in Windows …

87e908e

…Terminal" This reverts commit 91ce4ee.

Revert "Update build.py"

2b8f8ad

This reverts commit 25dc61a.

Update build.py

7e7590f

Multiply symbol calt snuck back in

b809795

Build update

f0911f3

Updating code for the build process and adding in a separate hinting file for the PL glyphs.

Merge remote-tracking branch 'upstream/master'

c9bc68e

Build.py & PL update

52a2951

Updates build script to include madig's modifications, plus adds static TTF export and autohinting using ttfautohint (if available). Also updated / renamed the Nerdfonts PL file.

Update build.py

5c43b1d

Merge remote-tracking branch 'upstream/master'

157badd

Implementing OVERLAP flags for simple / compound glyphs

6bda593

Merge branch 'master' into master

d327896

Update hyphen_less_less.liga.glif

bbbda38

Changing contour order for Extralight to resolve interpolation error

Merge branch 'master' of https://github.com/aaronbell/cascadia-code

558e071

Mid-Sept update

f03451a

1) Added support for Salishan language groups 2) Remastered mark positioning for glyphs with 2 diacritics (needed for Salishan) 3) Rebuild Build Script to simplify code 4) Fixed minor other hinting issues 5) Fixed RVRN substitutions for heavy weight

Update build.py

df1e455

Updating meta content

1ce0368

Clearing some additional metadata.

b13c3ac

Also it wants to update the hyphen glyph, but I don't see any specific changes.

Merge branch 'master' into salishan

6fbd061

Update build.py

b8f389c

Re-adding the static folder

Merge branch 'salishan'

055495c

Merge remote-tracking branch 'upstream/master'

f8207aa

Added multiprocessing

d796862

Merge remote-tracking branch 'upstream/master'

878f3ff

aaronbell added 3 commits February 12, 2021 19:11

Removing all background layers

f92795e

Merge branch 'main' into fixes

dfddfb9

Additional fixes!

426f2b4

- updates macronbelow design - increases overlap on middle positions for infinite arrows - remove iacute_j ligated forms, added jacute forms - removed Catalan locl substitutions - updated a couple of hints

aaronbell added 2 commits February 23, 2021 19:21

Update less_slash_greater.liga.glif

047505c

Forgot to set this back to 1200! Oops ❌

additional small fixes

68d1881

- reverted nameID 4 modification - disabled underline variation as MVAR not properly supported.

aaronbell mentioned this pull request Feb 24, 2021

Overly large leading in VS 2019 (not VS Code) for 2102.03 #413

Closed

DHowett approved these changes Feb 25, 2021

View reviewed changes

DHowett changed the title ~~Fixes~~ FIx issues in the Feb update Feb 25, 2021

DHowett changed the title ~~FIx issues in the Feb update~~ Fix issues in the Feb update Feb 25, 2021

DHowett merged commit f91a925 into microsoft:main Feb 25, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix issues in the Feb update #410

Fix issues in the Feb update #410

aaronbell commented Feb 13, 2021 •

edited

Loading

aaronbell commented Feb 17, 2021

DHowett commented Feb 24, 2021

aaronbell commented Feb 24, 2021

aaronbell commented Feb 24, 2021 •

edited

Loading

DHowett commented Feb 25, 2021

aaronbell commented Feb 25, 2021

DHowett commented Feb 25, 2021

DHowett commented Feb 25, 2021

aaronbell commented Feb 25, 2021

DHowett commented Feb 25, 2021

aaronbell commented Feb 25, 2021

DHowett commented Feb 25, 2021

aaronbell commented Feb 25, 2021

DHowett commented Feb 25, 2021

aaronbell commented Feb 25, 2021

aaronbell commented Feb 25, 2021

DHowett commented Feb 25, 2021

aaronbell commented Feb 25, 2021

aaronbell commented Feb 25, 2021

Fix issues in the Feb update #410

Fix issues in the Feb update #410

Conversation

aaronbell commented Feb 13, 2021 • edited Loading

Summary of the Pull Request

PR Checklist

Detailed Description of the Pull Request / Additional comments

aaronbell commented Feb 17, 2021

DHowett commented Feb 24, 2021

aaronbell commented Feb 24, 2021

aaronbell commented Feb 24, 2021 • edited Loading

DHowett commented Feb 25, 2021

aaronbell commented Feb 25, 2021

DHowett commented Feb 25, 2021

DHowett commented Feb 25, 2021

aaronbell commented Feb 25, 2021

DHowett commented Feb 25, 2021

aaronbell commented Feb 25, 2021

DHowett commented Feb 25, 2021

aaronbell commented Feb 25, 2021

DHowett commented Feb 25, 2021

aaronbell commented Feb 25, 2021

aaronbell commented Feb 25, 2021

DHowett commented Feb 25, 2021

aaronbell commented Feb 25, 2021

aaronbell commented Feb 25, 2021

aaronbell commented Feb 13, 2021 •

edited

Loading

aaronbell commented Feb 24, 2021 •

edited

Loading