Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Small gaps are visible in new arrow ligatures in the Konsole terminal emulator #414

Closed
schuelermine opened this issue Feb 14, 2021 · 3 comments · Fixed by #410
Closed

Small gaps are visible in new arrow ligatures in the Konsole terminal emulator #414

schuelermine opened this issue Feb 14, 2021 · 3 comments · Fixed by #410

Comments

@schuelermine
Copy link

Environment

Cascadia Code version number: 2102.003
Application (with version) used to display text: konsole 20.08.2
Font size: 11pt
Font variant: Cascadia Code Roman
OS: Pop!_OS 20.10
with Linux 5.8.0-7642-generic and GNOME 3.38.3
Screen resolution (i.e. 220dpi): 1920px×1080px
apparently 344mm×194mm (96x96dpi) according to xrandr and xdpyinfo
UI Scaling: 100%
Hinting setting: Slight (changed & reset recently)
Antialiasing: Standard (changed & reset recently)
Further settings: Large fonts accessibility option is enabled

Steps to reproduce

Get the terminal to render a combining arrow ligature

Expected behavior

Dashes / equal signs join exactly

Actual behavior

Small gaps

Screenshot

Screenshot from 2021-02-14 22-21-41
@aaronbell
Copy link
Collaborator

Do you see small gaps between box drawing characters?

for example ───────────┐

@schuelermine
Copy link
Author

Do you see small gaps between box drawing characters?

for example ───────────┐

No

Screenshot from 2021-02-15 12-17-25

@aaronbell
Copy link
Collaborator

Great! I’ll look into increasing the overlaps for the arrows.

@aaronbell aaronbell mentioned this issue Feb 17, 2021
Merged
7 tasks
DHowett pushed a commit that referenced this issue Feb 25, 2021
@aaronbell
Fix issues in the Feb update (#410)
f91a925 
A small set of fixes that resolves a couple of new bugs introduced in the latest version, plus other fixes I have been working on. 

## PR Checklist
* [x] Closes #406 - updated anchor type to lock with the other equals-related ligatures
* [x] Closes #408 - corrected component used for glyph to align with Unicode
* [x] Closes #412 - updated locl features removing iacute_j ligature and Catalan substitution
* [x] Closes #414 - increased overlaps of middle glyph for arrow ligatures
* [x] Closes #415 - reduces width of macronbelow
* [x] Closes #416 - rolls back name ID 4 modification as JetBrains cannot process it correctly
* [x] Closes #428 - rolls back variation of the underline to prevent MVAR table generation

## Detailed Description of the Pull Request / Additional comments

Full changelist:
- Repositioned tilde in related ligatures. Previously it was higher than the standard one.
- Added missing vietnamese anchors on acute and grave (futureproofing). 
- Corrected / made consistent greater & less positioning in </> and <$> related ligatures.
- Otherwise reviewed hinting
DHowett added a commit to microsoft/terminal that referenced this issue Feb 25, 2021
@DHowett
Update Cascadia Code to 2102.25
90936fe 
This update fixes some issues in Cascadia Code's February update:

microsoft/cascadia-code#406 - updated anchor type to lock with the other equals-related ligatures
microsoft/cascadia-code#408 - corrected component used for glyph to align with Unicode
microsoft/cascadia-code#412 - updated locl features removing iacute_j ligature and Catalan substitution
microsoft/cascadia-code#414 - increased overlaps of middle glyph for arrow ligatures
microsoft/cascadia-code#415 - reduces width of macronbelow
microsoft/cascadia-code#416 - rolls back name ID 4 modification as JetBrains cannot process it correctly
microsoft/cascadia-code#428 - rolls back variation of the underline to prevent MVAR table generation

Full changelist:
* Repositioned tilde in related ligatures. Previously it was higher than the standard one.
* Added missing vietnamese anchors on acute and grave (futureproofing).
* Corrected / made consistent greater & less positioning in </> and <$> related ligatures.
* Otherwise reviewed hinting
@DHowett DHowett mentioned this issue Feb 25, 2021
Merged
DHowett added a commit to microsoft/terminal that referenced this issue Feb 25, 2021
@DHowett
Update Cascadia Code to 2102.25 (#9295)
cb03b97 
This update fixes some issues in Cascadia Code's February update:

microsoft/cascadia-code#406 - updated anchor type to lock with the other equals-related ligatures
microsoft/cascadia-code#408 - corrected component used for glyph to align with Unicode
microsoft/cascadia-code#412 - updated locl features removing iacute_j ligature and Catalan substitution
microsoft/cascadia-code#414 - increased overlaps of middle glyph for arrow ligatures
microsoft/cascadia-code#415 - reduces width of macronbelow
microsoft/cascadia-code#416 - rolls back name ID 4 modification as JetBrains cannot process it correctly
microsoft/cascadia-code#428 - rolls back variation of the underline to prevent MVAR table generation

Full changelist:
* Repositioned tilde in related ligatures. Previously it was higher than the standard one.
* Added missing vietnamese anchors on acute and grave (futureproofing).
* Corrected / made consistent greater & less positioning in </> and <$> related ligatures.
* Otherwise reviewed hinting
DHowett added a commit to microsoft/terminal that referenced this issue Feb 25, 2021
@DHowett
Update Cascadia Code to 2102.25 (#9295)
f5f330a 
This update fixes some issues in Cascadia Code's February update:

microsoft/cascadia-code#406 - updated anchor type to lock with the other equals-related ligatures
microsoft/cascadia-code#408 - corrected component used for glyph to align with Unicode
microsoft/cascadia-code#412 - updated locl features removing iacute_j ligature and Catalan substitution
microsoft/cascadia-code#414 - increased overlaps of middle glyph for arrow ligatures
microsoft/cascadia-code#415 - reduces width of macronbelow
microsoft/cascadia-code#416 - rolls back name ID 4 modification as JetBrains cannot process it correctly
microsoft/cascadia-code#428 - rolls back variation of the underline to prevent MVAR table generation

Full changelist:
* Repositioned tilde in related ligatures. Previously it was higher than the standard one.
* Added missing vietnamese anchors on acute and grave (futureproofing).
* Corrected / made consistent greater & less positioning in </> and <$> related ligatures.
* Otherwise reviewed hinting

(cherry picked from commit cb03b97)
DHowett added a commit to microsoft/terminal that referenced this issue Feb 25, 2021
@DHowett
Update Cascadia Code to 2102.25 (#9295)
507a846 
This update fixes some issues in Cascadia Code's February update:

microsoft/cascadia-code#406 - updated anchor type to lock with the other equals-related ligatures
microsoft/cascadia-code#408 - corrected component used for glyph to align with Unicode
microsoft/cascadia-code#412 - updated locl features removing iacute_j ligature and Catalan substitution
microsoft/cascadia-code#414 - increased overlaps of middle glyph for arrow ligatures
microsoft/cascadia-code#415 - reduces width of macronbelow
microsoft/cascadia-code#416 - rolls back name ID 4 modification as JetBrains cannot process it correctly
microsoft/cascadia-code#428 - rolls back variation of the underline to prevent MVAR table generation

Full changelist:
* Repositioned tilde in related ligatures. Previously it was higher than the standard one.
* Added missing vietnamese anchors on acute and grave (futureproofing).
* Corrected / made consistent greater & less positioning in </> and <$> related ligatures.
* Otherwise reviewed hinting

(cherry picked from commit cb03b97)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix issues in the Feb update aaronbell/cascadia-code
2 participants
@aaronbell @schuelermine