This repository has been archived by the owner on Dec 4, 2023. It is now read-only.
[SDK][Bot-Dialogs] Update Recognizers-Text internal library #1020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update CosmosDbKeyEscape * Add comments and replace empty for isblank * Update CosmosDbKeyEscape.java Add missing closing parenthesis Co-authored-by: Martin Battaglino <[email protected]>
* Update CosmosDbPartitionedStorageOptions * Minor changes Co-authored-by: Martin Battaglino <[email protected]>
* Add missing tests * Update CosmosDBKeyEscapeTests * Add remaining tests, copyright Co-authored-by: Martin Battaglino <[email protected]>
* Update CosmosDbPartitionStorageTests * Unshort imports * Update libraries/bot-azure/src/test/java/com/microsoft/bot/azure/CosmosDbPartitionStorageTests.java Co-authored-by: Martin Battaglino <[email protected]> * Apply feedback Co-authored-by: Martin Battaglino <[email protected]>
* Fix null values * Update libraries/bot-azure/src/main/java/com/microsoft/bot/azure/CosmosDbKeyEscape.java Co-authored-by: Martin Battaglino <[email protected]> * Move compatibilityMode default value assignation Co-authored-by: Martin Battaglino <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #900
Fixes #901
Description
The Recognizers-Text repository was updated with new changes for the Java library, so the internal library can be updated with these changes.
Specific Changes
ChoicelibraryDatetimelibraryNumberlibraryNumberWithUnitlibraryMainlibraryExpressionlibrarySequencelibraryWe manually updated the resources of DateTime as the build in Java fails because the resources are not updated. We created the microsoft/Recognizers-Text#2508 to apply those changes in Recognizers-Text repository too.
Testing
Internal Recognizers-Text structure updated
mvn clean install passing correctly
