Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6558] Update to ANTLR 4.11 to compensate for breaking changes between versions #6586

Merged
merged 1 commit into from
Mar 8, 2023

Conversation

sw-joelmut
Copy link
Collaborator

Fixes #6558

Note: This PR was based on the changes made in the pull request #6557.

Description

This PR upgrades the ANTLR from 4.8.0 to 4.11.1 in the AdaptiveExpressions and LanguageGeneration libraries.

Specific Changes

  • Updates ANTLR dependency version from 4.8.0 to 4.11.1 in AdaptiveExpressions.csproj, Microsoft.Bot.Builder.LanguageGeneration.csproj and AdaptiveExpressions.Tests.csproj.
  • Updates the README.md files with the new commands to generate the files.
  • Updates all the files under the Generated folder with the commands listed in the README.md executing ANTLR.
  • Updates some .g4 files due to having a problem with the BOM encoding and EOF character.

Testing

The following image shows the build and test passing successfully with the applied changes.
image

@sw-joelmut sw-joelmut requested a review from a team as a code owner February 10, 2023 13:59
@sw-joelmut sw-joelmut added the Automation: No parity PR does not need to be applied to other languages. label Feb 10, 2023
@coveralls
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to ANTLR 4.11 to compensate for breaking changes between versions
3 participants