Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Templating] AdaptiveCards.Templating does not work with Applications using Bot Framework DotNet SDK 4.20.0 #8590

Closed
justin-mellor opened this issue Jun 29, 2023 · 3 comments
Assignees

Comments

@justin-mellor
Copy link

Platform

What platform is your issue or question related to? (Delete other platforms).

  • .NET

Author or host

Host running on ASP.NET Core 6.0 running Bot Framework

Version of SDK

AdaptiveCards.Templating 1.4.0

Issue

The June 2023 version of the Bot Framework (https://github.com/microsoft/botbuilder-dotnet/releases/tag/4.20.0) has changed to use ANTLR 4.11.1
See microsoft/botbuilder-dotnet#6558 and microsoft/botbuilder-dotnet#6586

AdaptiveCards.Templating is using ANTLR 4.8

Unfortunately ANTLR 4.10 (https://github.com/antlr/antlr4/releases/tag/4.10) seems to have broken the generated parsers and lexers in AdaptiveCards.Templating.

When creating a new AdaptiveCardTemplate class
new AdaptiveCardTemplate(templateJson).Expand(rootData)

we get a Type Initialization error
Method not found: 'Antlr4.Runtime.Atn.ATN Antlr4.Runtime.Atn.ATNDeserializer.Deserialize(Char[])'.

@jwoo-msft jwoo-msft self-assigned this Jun 29, 2023
@jwoo-msft
Copy link
Member

Thanks for reporting this issue. We will look into this issue.

@MattJam87
Copy link

+1 here

This incompatibility is very annoying! Is there any ETA on this?

Matt

@justin-mellor
Copy link
Author

This issue has been raised by somebody else as #8615
The other issue seems to be getting a bit more commenting on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Closed
Development

No branches or pull requests

3 participants