move allowed callers and skill conversation factory #5286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricDahlvang
approved these changes
Mar 9, 2021
This was referenced Mar 9, 2021
Closed
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moving a couple of classes out of adaptive runtime and into bot.builder and connector. And making these classes public.
We duplicate this code in a number of places: samples and tests.
The allowedcallers code should depend on BotFrameworkAuthentication rather than GetAppIdFromClaims directly, though that might not be critical path.
Note the samples and some test code derived from it make the concepts of allowed callers and allowed skills distinct - even though they are the same validation of appId. And they therefore read different configuration for each. The adaptive runtime didn't follow this pattern and so we only need AllowedCallersClaimsValidator and not AllowedSkillsClaimsValidator.