Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

port: move allowed callers and skill conversation factory (#5286) #1041

Closed
github-actions bot opened this issue Mar 9, 2021 · 1 comment · Fixed by #1062
Closed

port: move allowed callers and skill conversation factory (#5286) #1041

github-actions bot opened this issue Mar 9, 2021 · 1 comment · Fixed by #1062
Assignees
@LeeParrishMSFT
Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms.

Comments

@github-actions
Copy link

github-actions bot commented Mar 9, 2021

The changes in move allowed callers and skill conversation factory (#5286) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Moving a couple of classes out of adaptive runtime and into bot.builder and connector. And making these classes public.

We duplicate this code in a number of places: samples and tests.

The allowedcallers code should depend on BotFrameworkAuthentication rather than GetAppIdFromClaims directly, though that might not be critical path.

Note the samples and some test code derived from it make the concepts of allowed callers and allowed skills distinct - even though they are the same validation of appId. And they therefore read different configuration for each. The adaptive runtime didn't follow this pattern and so we only need AllowedCallersClaimsValidator and not AllowedSkillsClaimsValidator.

Please review and, if necessary, port the changes.
@github-actions github-actions bot added ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms. labels Mar 9, 2021
@LeeParrishMSFT LeeParrishMSFT mentioned this issue Mar 18, 2021
Merged
@LeeParrishMSFT
Copy link
Contributor

Closed with PR #1062

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@LeeParrishMSFT LeeParrishMSFT

Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Move allowed callers and skill conversation factory to SDK microsoft/botbuilder-java
1 participant
@LeeParrishMSFT