Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

undo blocking on token polling ops; add docs & comments #4680

Merged
merged 1 commit into from
Sep 21, 2020

Conversation

stevengum
Copy link
Member

Fixes #4673 in main


Copy-paste from PR #4675:

Specific Changes

  • Change from Task.WaitAll() to Task.WhenAll() to not block background polling operations
    • This is spiritual a "reversion" of some code factoring in the 4.10.0 release
  • Add comments/documentation explaining what the code is doing to prevent future breaks
  • Fix minor typo

Testing

Manually tested these changes along with a fix for microsoft/BotFramework-WebChat#3439 and the workaround mentioned in #4674 with Direct Line ASE and Direct Line Speech. The OAuth flow works as expected.

Note: No magic-code OAuth flows are not supported outside of regular Direct Line with Enhanced Authentication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Blocking on polling operations prevents OAuth from working in Streaming scenarios
3 participants