undo blocking on token polling ops; add docs & comments #4680
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4673 in
main
Copy-paste from PR #4675:
Specific Changes
Task.WaitAll()
toTask.WhenAll()
to not block background polling operationsTesting
Manually tested these changes along with a fix for microsoft/BotFramework-WebChat#3439 and the workaround mentioned in #4674 with Direct Line ASE and Direct Line Speech. The OAuth flow works as expected.
Note: No magic-code OAuth flows are not supported outside of regular Direct Line with Enhanced Authentication.