Inconsistent return types in CardActionContext.getSignInUrl()

[stevengum]

Line 118 returns a Promise, but line 125 returns a string or undefined:

BotFramework-WebChat/packages/component/src/Composer.js

Lines 108 to 125 in 906de77

	getSignInUrl:
	cardAction.type === 'signin'
	? () => {
	const { value } = cardAction;
	if (directLine.getSessionId) {
	// TODO: [P3] We should change this one to async/await.
	// This is the first place in this project to use async.
	// Thus, we need to add @babel/plugin-transform-runtime and @babel/runtime.
	return observableToPromise(directLine.getSessionId()).then(
	sessionId => `${value}${encodeURIComponent(`&code_challenge=${sessionId}`)}`
	);
	}
	console.warn('botframework-webchat: OAuth is not supported on this Direct Line adapter.');
	return value;

This causes an exception in createDefaultCardActionMiddleware() where it expects getSignInUrl to return a Promise:

BotFramework-WebChat/packages/component/src/Middleware/CardAction/createCoreMiddleware.js

Lines 75 to 79 in b47cdac

	const popup = window.open();
	getSignInUrl().then(url => {
	popup.location.href = url;
	});

This issue was discovered while trying to use OAuth + Streaming (specifically DL ASE), though directLine.getSessionId may be falsey, the return values should have the same type.

---

Possible fix:

One solution is to return Promise.resolve(value); instead of return value;

FYI @jiruss, @DDEfromOR, @ckkashyap, @anusharavindrar

[stevengum]

As an aside, using this resulted in a partially successful OAuthPrompt flow when using Direct Line ASE. (The signInUrl link worked as expected)

However, attempts to use the magic code post-successful login through the OAuth provider failed.

[stevengum]

Update: I've successfully tested this fix along with a fix for microsoft/botbuilder-dotnet#4673 and the workaround mentioned in microsoft/botbuilder-dotnet#4674 with Direct Line ASE and Direct Line Speech. The OAuth flow works as expected.

Note: No magic-code OAuth flows are not supported outside of regular Direct Line with Enhanced Authentication.