Map different ring names to git branches #1313
Comments
|
@samiyaakhtar if the branch name is now different from the ring name you would need to look at @bnookala @evanlouie The customer said this is low priority. I think so too at the moment so we can take our time to think about this. I would put other refactoring and testing ahead of this. |
|
@evanlouie @andrebriggs Just created #1396 as a follow up task |
- Rings in `bedrock.yaml` now contain a `targetBranch` (set via
`--target-branch` flag on `ring create`).
- The `targetBranch` is used as the the trigger branch for the
serve-build-and-update pipelines; Added during `ring create` time.
- The HLD repository now follows a directory structure of:
```
HLD
├── component.yaml
└── my-application
├── access.yaml
├── config
│ └── common.yaml
├── component.yaml
└── <service-name>
├── config
│ └── common.yaml
├── component.yaml
└── <branch-name> # Is no longer always the name of the ring -- uses targetBranch if it was provided and the ring name as fallback
├── component.yaml
├── config
│ └── common.yaml
└── static
├── ingress-route.yaml # still matches on a `Ring` header for the ring name
└── middlewares.yaml
```
closes microsoft/bedrock#1313
- Rings in `bedrock.yaml` now contain a `targetBranch` (set via
`--target-branch` flag on `ring create`).
- The `targetBranch` is used as the the trigger branch for the
serve-build-and-update pipelines; Added during `ring create` time.
- The HLD repository now follows a directory structure of:
```
HLD
├── component.yaml
└── my-application
├── access.yaml
├── config
│ └── common.yaml
├── component.yaml
└── <service-name>
├── config
│ └── common.yaml
├── component.yaml
└── <branch-name> # Is no longer always the name of the ring -- uses targetBranch if it was provided and the ring name as fallback
├── component.yaml
├── config
│ └── common.yaml
└── static
├── ingress-route.yaml # still matches on a `Ring` header for the ring name
└── middlewares.yaml
```
closes microsoft/bedrock#1313
- Rings in `bedrock.yaml` now contain a `targetBranch` (set via
`--target-branch` flag on `ring create`).
- The `targetBranch` is used as the the trigger branch for the
serve-build-and-update pipelines; Added during `ring create` time.
- The HLD repository now follows a directory structure of:
```
HLD
├── component.yaml
└── my-application
├── access.yaml
├── config
│ └── common.yaml
├── component.yaml
└── <service-name>
├── config
│ └── common.yaml
├── component.yaml
└── <branch-name> # Is no longer always the name of the ring -- uses targetBranch if it was provided and the ring name as fallback
├── component.yaml
├── config
│ └── common.yaml
└── static
├── ingress-route.yaml # still matches on a `Ring` header for the ring name
└── middlewares.yaml
```
closes microsoft/bedrock#1313
- Rings in `bedrock.yaml` now contain a `targetBranch` (set via
`--target-branch` flag on `ring create`).
- The `targetBranch` is used as the the trigger branch for the
serve-build-and-update pipelines; Added during `ring create` time.
- The HLD repository now follows a directory structure of:
```
HLD
├── component.yaml
└── my-application
├── access.yaml
├── config
│ └── common.yaml
├── component.yaml
└── <service-name>
├── config
│ └── common.yaml
├── component.yaml
└── <branch-name> # Is no longer always the name of the ring -- uses targetBranch if it was provided and the ring name as fallback
├── component.yaml
├── config
│ └── common.yaml
└── static
├── ingress-route.yaml # still matches on a `Ring` header for the ring name
└── middlewares.yaml
```
closes microsoft/bedrock#1313
|
After deeper investigation and attempts at a not too intrusive solution, I believe this cannot be completed without very heavy refactoring of the service build-update pipeline. Looking for feedback to see if this feature is worth such refactoring. Notes on what would need to be done captured in: microsoft/bedrock-cli#36
I'm leaning towards such refactoring and increase in complexity of the pipeline not being worth the feature -- @andrebriggs @bnookala @mtarng |
|
Putting this back in the backlog it becomes a higher priority. Requires deeper design review to come up with solution to address whats mentioned above |
As a:
SPK User
I want:
To map different ring names to git branches
So that:
My ring names don't have to be the same as the git branch names
Describe the solution you'd like:
Perhaps some sort of mapping in bedrock.yaml that allows a ring name to target a git branch name, allowing a user to specify a git branch to use for a ring ie
Though perhaps the ideal schema should be inverted to be branch name as the key, and the target ring name as the value ie - we should spend some time figuring out what makes sense here
Acceptance Criteria:
Describe alternatives you've considered:
This is a preliminary investigation into how we might map different rings to branches - there may exist other methods of solving this.
Additional context:
Customer request
Does this require updates to documentation?:
Yes
The text was updated successfully, but these errors were encountered: