This repository has been archived by the owner on Nov 16, 2023. It is now read-only.
Add branch mapping to rings #36
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Rings in `bedrock.yaml` now contain a `targetBranch` (set via
`--target-branch` flag on `ring create`).
- The `targetBranch` is used as the the trigger branch for the
serve-build-and-update pipelines; Added during `ring create` time.
- The HLD repository now follows a directory structure of:
```
HLD
├── component.yaml
└── my-application
├── access.yaml
├── config
│ └── common.yaml
├── component.yaml
└── <service-name>
├── config
│ └── common.yaml
├── component.yaml
└── <branch-name> # Is no longer always the name of the ring -- uses targetBranch if it was provided and the ring name as fallback
├── component.yaml
├── config
│ └── common.yaml
└── static
├── ingress-route.yaml # still matches on a `Ring` header for the ring name
└── middlewares.yaml
```
closes microsoft/bedrock#1313
5 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THIS PR IS INCOMPLETE -- SEEKING FEEDBACK
This PR is an initial attempt to add the ability to map custom branches to
rings. After investigation and attempts at implementation, I've come to the
conclusion that without a major refactor to the service-build-update pipeline,
adding this functionality cannot be done cleanly.
Problems:
cdinto prior to callingfab setto update the image tag.pipeline would need to be able to update multiple rings -- requiring parsing
of bedrock.yaml.
To get around this problems, we would need to the ability to parse the
bedrock.yaml file in the build-update pipeline. To do so, we would need to
implement a pseudo
hld reconcile-like function which would be called in thepipeline -- meaning the build-update pipeline would require the bedrock-cli as
well (just like the lifecycle pipeline).
I do not believe that the additional functionally of target branches for rings
worth this jump in complexity for hte pipeline.
closes microsoft/bedrock#1313