Execute bash script instead of sourcing #9534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtbassmatt
reviewed
Feb 8, 2019
jtpetty
reviewed
Sep 19, 2019
Tasks/BashV3/bash.ts
Outdated
| // Check if executable bit is set | ||
| let stats: fs.Stats = fs.statSync(targetFilePath); | ||
| if ((stats.mode & 1) > 0) { | ||
| contents = `sh '${targetFilePath.replace("'", "'\\''")}' ${input_arguments}`.trim(); |
There was a problem hiding this comment.
is the purpose to run the script in a sub-shell? Should we use 'bash' instead of 'sh' since 'sh' is not guaranteed to the 'bash' on all systems.
There was a problem hiding this comment.
Yeah, that's a good catch, updated appropriately
|
LGTM |
jtpetty
approved these changes
Sep 19, 2019
damccorm
pushed a commit
that referenced
this pull request
Oct 16, 2019
This reverts commit 676cd20.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AZP_BASHV3_OLD_SOURCE_BEHAVIOR. If it'strue, use the old (current) behavior.Fixes #7934