Source bash tasks instead of executing them #11760

damccorm · 2019-11-13T18:45:01Z

Check a variable AZP_BASHV3_OLD_SOURCE_BEHAVIOR. If it's true, use the old (current) behavior.
Otherwise, check the executable bit. If set, run the script.
If not set, throw a warning and use the old behavior. This warning will include a pointer to docs which illustrate the back-compat variable.

We did this in #9534 and then had to revert in #11571 because of an error, you can see that I'm not making the same mistake here (I've called out where it was) and I've added testing

damccorm · 2019-11-13T18:47:20Z

Tasks/BashV3/bash.ts

+                contents = `. '${targetFilePath.replace("'", "'\\''")}' ${input_arguments}`.trim();
+            } else {
+                // Check if executable bit is set
+                let stats: fs.Stats = tl.stats(input_filePath);


This is where the mistake was last time - in the last iteration of this PR, I was doing a stats call on targetFilePath instead of input_filePath. This is a problem because targetFilePath gets some modifications on just windows so that it will work with bash, that cause stats to fail.

zachariahcox · 2019-11-25T19:46:52Z

@stephenmichaelf are you okay with this change?

damccorm · 2019-12-12T20:53:06Z

@stephenmichaelf could you take a look?

Tasks/BashV3/bash.ts

stephenmichaelf

Approving with comments.

Source bash tasks instead of executing them

dd1f931

damccorm requested a review from jtpetty as a code owner November 13, 2019 18:45

Bump version

c118e51

damccorm commented Nov 13, 2019

View reviewed changes

damccorm requested a review from stephenmichaelf November 13, 2019 20:18

Merge branch 'master' into users/damccorm/source

df76588