-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DownloadBuildArtifacts - Use latest build filtered by branch #6356
Changes from 9 commits
494949e
d54d4fc
e9ac698
7b77c18
2fc8e9a
2fb5edb
fb71712
28a5f97
71e6d09
cad3594
f17b01a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -8,7 +8,7 @@ | |
"author": "Microsoft Corporation", | ||
"version": { | ||
"Major": 0, | ||
"Minor": 132, | ||
"Minor": 133, | ||
"Patch": 0 | ||
}, | ||
"groups": [ | ||
|
@@ -67,13 +67,35 @@ | |
"visibleRule": "buildType == specific", | ||
"helpMarkDown": "If checked, this build task will try to download artifacts from the triggering build. If there is no triggering build from the specified definition, it will download artifacts from the build specified in the options below." | ||
}, | ||
{ | ||
"name": "buildVersionToDownload", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. folks only see the label. Is there a reason to rename the name? It will cause the tasks to get redownloaded since I believe the folder is by name + guid. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. What does this mean to yaml and all our docs and templates? Is this rename really worth it? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a naming change of a field that is added as part of this feature (initially implemented by me, named 'artifactVersion'). On top of that, this is only a renaming of this parameter, not the renaming of the whole step. I dont think this is breaking in any way. With this, I dont see how this affects the yaml/docs... Or am I missing something here? |
||
"type": "pickList", | ||
"label": "Build version to download", | ||
"defaultValue": "latest", | ||
"visibleRule": "buildType == specific", | ||
"required": true, | ||
"options": { | ||
"latest": "Latest", | ||
"latestFromBranch": "Latest from specific branch", | ||
"specific": "Specific version" | ||
} | ||
}, | ||
{ | ||
"name": "branchName", | ||
"type": "string", | ||
"label": "Branch name", | ||
"defaultValue": "refs/heads/master", | ||
"visibleRule": "buildType == specific && buildVersionToDownload == latestFromBranch", | ||
"required": true, | ||
"helpMarkDown": "Specify to filter on branch/ref name, for example: ```refs/heads/develop```." | ||
}, | ||
{ | ||
"name": "buildId", | ||
"type": "pickList", | ||
"label": "Build", | ||
"defaultValue": "", | ||
"required": true, | ||
"visibleRule": "buildType == specific", | ||
"visibleRule": "buildType == specific && buildVersionToDownload == specific", | ||
"properties": { | ||
"EditableOptions": "True", | ||
"DisableManageLink": "True" | ||
|
@@ -196,6 +218,9 @@ | |
"ArtifactsSuccessfullyDownloaded": "Successfully downloaded artifacts to %s", | ||
"RetryingOperation" : "Error : in %s, so retrying => retries pending : %s", | ||
"OperationFailed": "Failed in %s with error: %s", | ||
"ArtifactNameDirectoryNotFound": "Directory '%s' does not exist. Falling back to parent directory: %s" | ||
"ArtifactNameDirectoryNotFound": "Directory '%s' does not exist. Falling back to parent directory: %s", | ||
"LatestBuildFound": "Latest build found: %s", | ||
"LatestBuildNotFound":"Latest build not found", | ||
"LatestBuildFromBranchNotFound":"Latest build from branch %s not found" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
leave blank line after previous if block