DownloadBuildArtifacts - Use latest build filtered by branch #6356

keesschollaart81 · 2018-02-02T14:58:17Z

Implements #6076

GitHubSriramB · 2018-02-09T08:03:24Z

It would be better to let user select "Latest" as value for Build version & "Any" or "*" for the branch rather than letting them be empty.
We should have Branch input appear before Build so that Builds are listed from the selected branch.

keesschollaart81 · 2018-02-09T14:29:26Z

Thanks, great ideas! I'll try to implement them next week and update the PR!

keesschollaart81 · 2018-02-16T16:24:56Z

Just updated the PR with an updated UI. Regarding 2), I chose a slightly different approach by using a combo to only show one of the two inputs (branche-name or build-id) because you would never use them in conjunction.

Let me know if you find this better or if I can still improve the UI experience / labels...

GitHubSriramB · 2018-02-20T09:58:00Z

@keesschollaart81 -

Rename "Latest" to "Latest build from specific branch"?
Rename "Specific buildnumber" to "Specific build"?

GitHubSriramB · 2018-02-20T10:05:43Z

Tasks/DownloadBuildArtifacts/main.ts

@@ -126,12 +128,28 @@ async function main(): Promise<void> {
                // Triggering build info not found, or requested, default to specified build info
                projectId = tl.getInput("project", true);
                definitionId = definitionIdSpecified;
-                buildId = parseInt(tl.getInput("buildId", true));
+                buildId = parseInt(tl.getInput("buildId", false));


we should make sure buildId is specified when the option chosen is specific build.

GitHubSriramB · 2018-02-20T10:06:05Z

Tasks/DownloadBuildArtifacts/main.ts

            }
        }

        // verify that buildId belongs to the definition selected
        if (definitionId) {
+            if (!buildId){ 
+                // get latest successful build filtered by branch


we should do this only when "latest build" option is chosen

…-checks)

keesschollaart81 · 2018-02-27T08:59:08Z

Agree! Done!

leidegre · 2018-03-08T13:12:38Z

Any idea when this will be available for everyone generally? Killer feature for my use case right now and something I've been missing from VSTS.

ashokirla · 2018-03-09T06:48:35Z

@keesschollaart81
This is a great feature and we love it. Just few recommendations:
Instead of using radio buttons for “Download artifacts produced by” , I would suggest we have similar experience we have in our artifacts linking. See

Instead of using “Download artifacts produced by” parameter with radio buttons, we can have “Artifact version” as the parameter name with a drop down. And the dropdown can have below entries.

Latest
Latest from specific branch
Specific version.
Rest of the experience stays the same.
This way the experience will be consistent across. And going forward if we chose to add more options, this design will scale.

Discussed the same with @GitHubSriramB and this will be the final set of changes :).

keesschollaart81 · 2018-03-09T10:26:36Z

Great! Like it, done!

GitHubSriramB · 2018-03-14T11:03:04Z

@keesschollaart81 - one last comment reg. the name for the name for the version input. Instead of naming it "Artifact version", can you name it as "Build version to download"? Since there are artifacts within a Build & the version we are providing as input is for the Build that is applicable for all the artifacts, wanted to avoid naming it as "Artifact version" & causing any confusion.

already discussed this suggestion with @ashokirla and he is fine with this too.

GitHubSriramB · 2018-03-14T11:09:52Z

Tasks/DownloadBuildArtifacts/main.ts

+                console.log(tl.loc("LatestBuildFound", buildsForThisDefinition[0].id));
+                buildId = buildsForThisDefinition[0].id
+            } 
+


can we reuse the build we got in case version is latest or latestFromBranch instead of calling getBuild again in line 156?

Yes, nice catch! Implemented & tested!

…oad + perf optmization

keesschollaart81 · 2018-03-14T15:27:37Z

Again... 👍

bryanmacfarlane · 2018-03-14T15:38:26Z

Tasks/DownloadBuildArtifacts/task.json

@@ -68,9 +68,9 @@
      "helpMarkDown": "If checked, this build task will try to download artifacts from the triggering build. If there is no triggering build from the specified definition, it will download artifacts from the build specified in the options below."
    },
    {
-      "name": "artifactVersion",
+      "name": "buildVersionToDownload",


folks only see the label. Is there a reason to rename the name? It will cause the tasks to get redownloaded since I believe the folder is by name + guid.

What does this mean to yaml and all our docs and templates? Is this rename really worth it?

This is a naming change of a field that is added as part of this feature (initially implemented by me, named 'artifactVersion'). On top of that, this is only a renaming of this parameter, not the renaming of the whole step. I dont think this is breaking in any way. With this, I dont see how this affects the yaml/docs... Or am I missing something here?

GitHubSriramB · 2018-03-15T09:29:02Z

Tasks/DownloadBuildArtifacts/main.ts

+                console.log(tl.loc("LatestBuildFound", build.id));
+                buildId = build.id
+            } 
+            if (!build){


leave blank line after previous if block

drewkg · 2018-03-20T14:14:19Z

With Sprint 131 now being rolled out, the addition of this capability as a build task would significantly reduce the number of custom scripts that are currently in place to perform the same task.

omeshp · 2018-03-22T08:52:57Z

@drewkg This feature will be deployed with M133 changes.

drewkg · 2018-03-22T09:47:09Z

Thanks for the timeline.

leidegre · 2018-03-22T13:16:17Z

@omeshp what does M133 mean? Where can I find a reference to that, or an actual time frame?

madhurig · 2018-03-22T13:27:42Z

@leidegre: VSTS deploys fixes and features generally on a 3 week cadence/sprints. Currently deployed version in production is M131 (milestone 131): https://docs.microsoft.com/en-us/vsts/release-notes/2018/mar-05-vsts.

M133 will start deploying after April 15th. We do a staged rollout - generally within 2 weeks all the VSTS accounts will have the updates.

Thanks,
Madhuri

steve-hawkins · 2018-03-27T18:55:46Z

The version 0.131.1 of Download Build Artifacts shows the Build picklist as version numbers in the Release Definition UI and currently does not appear to allow variables to be used as the 'buildId' input:-

specify a variable with target version number:-
download_version=1.0.14.1

==============================================================================
Task         : Download Build Artifacts
Description  : Download Build Artifacts
Version      : 0.131.1
Author       : Microsoft Corporation
Help         : 
==============================================================================
##[error]Build with id NaN not found for build definition id [REDACTED]

can you confirm if the 'buildVersionToDownload' input in this version of Download Build Artifacts will accept a version number variable?

doormalena · 2018-03-27T21:57:45Z

Is it possible somehow to obtain the value of the "build.sourceLabel" artifact (preferably available as a variable) together with the new option to always use the latest build version available?

Background: we have a CI build publishing an artifact. Using another build definition we collect this artifact (using this build task) and generate a product package (MSI etc.). We need the version number of the CI build output to be set as the version number of this build definition (and the MSI). I was thinking of using ##vso[build.updatebuildnumber] for this accompanied with the value of "build.sourceLabel".

gertvdh · 2018-04-24T09:33:55Z

This got installed on our account this week, this increases our productivity, thanks for the effort!

thecontrarycat · 2018-06-27T08:42:17Z

Is there any way to update this task for OnPrem TFS 2018? I really need this feature to fix our releases...

romil07 · 2018-07-02T06:22:50Z

@thecontrarycat
You can have this update but following scenario won't work for OnPrem TFS 2018:

The checkbox "When appropriate, download artifacts from triggering build" option won't work for you. This was released after the TFS 2018 was shipped and hence, it's available only for the online users as of now or the TFS 2018 update 2 users.

If you are okay with this, let me know. I will give you the steps to update the task.

t3mi · 2018-08-22T14:17:37Z

@keesschollaart81
Any chance you can add BuildResult.PartiallySucceeded as an additional option for the filtering when you searching for builds (Line 143)? Or at least please change the inputs/docs that you are searching for the latest succeeded build.

keesschollaart81 · 2018-08-22T16:05:47Z

I don't know, what do @GitHubSriramB or @ashokirla think? I wont be able to implement this in the next 6 weeks, at least. Why don't you pop a PR yourself? ;-)

DownloadBuildArtifacts - Use latest build filtered by branch

494949e

kmkumaran assigned GitHubSriramB Feb 6, 2018

kmkumaran added the Area: Release label Feb 6, 2018

GitHubSriramB requested a review from omeshp February 6, 2018 08:42

Kees Schollaart added 3 commits February 16, 2018 17:03

Updating UI experience for 'latest build' feature

d54d4fc

Bumping the task version

e9ac698

Fixing merge conflict

7b77c18

GitHubSriramB reviewed Feb 20, 2018

View reviewed changes

GitHubSriramB mentioned this pull request Feb 22, 2018

Download Build Artifacts (Preview) - latest build from a branch #6496

Closed

DownloadBuildArtifacts: Implemented proposed changes (naming and flow…

2fc8e9a

…-checks)

keesschollaart81 added 2 commits February 27, 2018 19:57

Resolved merge conflict / updated task version

2fb5edb

Merge branch 'master' into master

fb71712

DownloadBuildArtifacts ArtifactVersion: Switching from radio to picklist

28a5f97

omeshp approved these changes Mar 13, 2018

View reviewed changes

GitHubSriramB approved these changes Mar 14, 2018

View reviewed changes

DownloadBuildArtifacts: Rename ArtifactVersion to BuildVersionToDownl…

71e6d09

…oad + perf optmization

bryanmacfarlane reviewed Mar 14, 2018

View reviewed changes

GitHubSriramB approved these changes Mar 15, 2018

View reviewed changes

Adding some whitelines

cad3594

Another whiteline

f17b01a

omeshp merged commit ca7ab3d into microsoft:master Mar 22, 2018

GitHubSriramB mentioned this pull request Mar 23, 2018

Specific Build: Get latest successful buildID #6753

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DownloadBuildArtifacts - Use latest build filtered by branch #6356

DownloadBuildArtifacts - Use latest build filtered by branch #6356

keesschollaart81 commented Feb 2, 2018

GitHubSriramB commented Feb 9, 2018

keesschollaart81 commented Feb 9, 2018

keesschollaart81 commented Feb 16, 2018

GitHubSriramB commented Feb 20, 2018 •

edited

Loading

GitHubSriramB Feb 20, 2018

GitHubSriramB Feb 20, 2018

keesschollaart81 commented Feb 27, 2018

leidegre commented Mar 8, 2018

ashokirla commented Mar 9, 2018

keesschollaart81 commented Mar 9, 2018

GitHubSriramB commented Mar 14, 2018 •

edited

Loading

GitHubSriramB Mar 14, 2018

keesschollaart81 Mar 14, 2018

keesschollaart81 commented Mar 14, 2018

bryanmacfarlane Mar 14, 2018

bryanmacfarlane Mar 14, 2018

keesschollaart81 Mar 14, 2018

GitHubSriramB Mar 15, 2018

drewkg commented Mar 20, 2018

omeshp commented Mar 22, 2018

drewkg commented Mar 22, 2018

leidegre commented Mar 22, 2018

madhurig commented Mar 22, 2018

steve-hawkins commented Mar 27, 2018

doormalena commented Mar 27, 2018 •

edited

Loading

gertvdh commented Apr 24, 2018

thecontrarycat commented Jun 27, 2018

romil07 commented Jul 2, 2018

t3mi commented Aug 22, 2018 •

edited

Loading

keesschollaart81 commented Aug 22, 2018

DownloadBuildArtifacts - Use latest build filtered by branch #6356

DownloadBuildArtifacts - Use latest build filtered by branch #6356

Conversation

keesschollaart81 commented Feb 2, 2018

GitHubSriramB commented Feb 9, 2018

keesschollaart81 commented Feb 9, 2018

keesschollaart81 commented Feb 16, 2018

GitHubSriramB commented Feb 20, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

keesschollaart81 commented Feb 27, 2018

leidegre commented Mar 8, 2018

ashokirla commented Mar 9, 2018

keesschollaart81 commented Mar 9, 2018

GitHubSriramB commented Mar 14, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

keesschollaart81 commented Mar 14, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

drewkg commented Mar 20, 2018

omeshp commented Mar 22, 2018

drewkg commented Mar 22, 2018

leidegre commented Mar 22, 2018

madhurig commented Mar 22, 2018

steve-hawkins commented Mar 27, 2018

doormalena commented Mar 27, 2018 • edited Loading

gertvdh commented Apr 24, 2018

thecontrarycat commented Jun 27, 2018

romil07 commented Jul 2, 2018

t3mi commented Aug 22, 2018 • edited Loading

keesschollaart81 commented Aug 22, 2018

GitHubSriramB commented Feb 20, 2018 •

edited

Loading

GitHubSriramB commented Mar 14, 2018 •

edited

Loading

doormalena commented Mar 27, 2018 •

edited

Loading

t3mi commented Aug 22, 2018 •

edited

Loading