-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move azure-arm-rest to Common directory #4527
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
{ | ||
"common": [ | ||
{ | ||
"module": "../Common/azure-arm-rest", | ||
"type": "node", | ||
"dest": "./", | ||
"compile" : true | ||
} | ||
] | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
{ | ||
"loc.messages.ClientIdCannotBeEmpty": "clientId must be a non empty string.", | ||
"loc.messages.DomainCannotBeEmpty": "domain must be a non empty string.", | ||
"loc.messages.SecretCannotBeEmpty": "secret must be a non empty string.", | ||
"loc.messages.armUrlCannotBeEmpty": "arm Url must be a non empty string.", | ||
"loc.messages.authorityUrlCannotBeEmpty": "authority must be a non empty string.", | ||
"loc.messages.CouldNotFetchAccessTokenforAzureStatusCode": "Could not fetch access token for azure. Status code: %s, status message: %s", | ||
"loc.messages.CallbackCannotBeNull": "callback cannot be null.", | ||
"loc.messages.VMNameCannotBeNull": "vmName cannot be null or undefined and it must be of type string.", | ||
"loc.messages.InvalidValue": "%s is not a valid value. The valid values are: %s", | ||
"loc.messages.VmExtensionNameCannotBeNull": "vmExtensionName cannot be null or undefined and it must be of type string.", | ||
"loc.messages.ExpandShouldBeOfTypeString": "expand must be of type string.", | ||
"loc.messages.ExtensionParametersCannotBeNull": "extensionParameters cannot be null or undefined.", | ||
"loc.messages.LoadBalancerNameCannotBeNull": "'loadBalancerName cannot be null or undefined and it must be of type string.'", | ||
"loc.messages.ParametersCannotBeNull": "parameters cannot be null or undefined.", | ||
"loc.messages.NetworkInterfaceNameCannotBeNull": "networkInterfaceName cannot be null or undefined and it must be of type string.", | ||
"loc.messages.NetworkSecurityGroupNameCannotBeNull": "networkSecurityGroupName cannot be null or undefined and it must be of type string.", | ||
"loc.messages.SecurityRuleNameCannotBeNull": "securityRuleName cannot be null or undefined and it must be of type string.", | ||
"loc.messages.SecurityRuleParametersCannotBeNull": "securityRuleParameters cannot be null or undefined.", | ||
"loc.messages.DeploymentNameCannotBeNull": "deploymentName cannot be null or undefined and it must be of type string.", | ||
"loc.messages.CredentialsCannotBeNull": "'credentials' cannot be null.", | ||
"loc.messages.SubscriptionIdCannotBeNull": "'subscriptionId' cannot be null.", | ||
"loc.messages.InvalidResponseLongRunningOperation": "Invalid response received for fetching status of a long running operation.", | ||
"loc.messages.TimeoutWhileWaiting": "Timed out while waiting", | ||
"loc.messages.ResourceGroupCannotBeNull": "resourceGroupName cannot be null or undefined and it must be of type string.", | ||
"loc.messages.ResourceGroupExceededLength": "\"resourceGroupName\" should satisfy the constraint - \"MaxLength\": 90", | ||
"loc.messages.ResourceGroupDeceededLength": "\"resourceGroupName\" should satisfy the constraint - \"MinLength\": 1", | ||
"loc.messages.ResourceGroupDoesntMatchPattern": "\"resourceGroupName\" should satisfy the constraint - \"Pattern\": /^[-\\w\\._\\(\\)]+$/" | ||
} | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. do verify if these strings are getting picked or not, if there are duplicate keys. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As per other common module, this should work. I will test after removing strings from task. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This does not work with module.json. I have sent a mail to Eric/Bryan asking for any work-around. In the meanwhile I will not remove these strings from task.json. |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
{ | ||
"messages": { | ||
"ClientIdCannotBeEmpty": "clientId must be a non empty string.", | ||
"DomainCannotBeEmpty": "domain must be a non empty string.", | ||
"SecretCannotBeEmpty": "secret must be a non empty string.", | ||
"armUrlCannotBeEmpty": "arm Url must be a non empty string.", | ||
"authorityUrlCannotBeEmpty": "authority must be a non empty string.", | ||
"CouldNotFetchAccessTokenforAzureStatusCode": "Could not fetch access token for azure. Status code: %s, status message: %s", | ||
"CallbackCannotBeNull": "callback cannot be null.", | ||
"VMNameCannotBeNull": "vmName cannot be null or undefined and it must be of type string.", | ||
"InvalidValue": "%s is not a valid value. The valid values are: %s", | ||
"VmExtensionNameCannotBeNull": "vmExtensionName cannot be null or undefined and it must be of type string.", | ||
"ExpandShouldBeOfTypeString": "expand must be of type string.", | ||
"ExtensionParametersCannotBeNull": "extensionParameters cannot be null or undefined.", | ||
"LoadBalancerNameCannotBeNull": "'loadBalancerName cannot be null or undefined and it must be of type string.'", | ||
"ParametersCannotBeNull": "parameters cannot be null or undefined.", | ||
"NetworkInterfaceNameCannotBeNull": "networkInterfaceName cannot be null or undefined and it must be of type string.", | ||
"NetworkSecurityGroupNameCannotBeNull": "networkSecurityGroupName cannot be null or undefined and it must be of type string.", | ||
"SecurityRuleNameCannotBeNull": "securityRuleName cannot be null or undefined and it must be of type string.", | ||
"SecurityRuleParametersCannotBeNull": "securityRuleParameters cannot be null or undefined.", | ||
"DeploymentNameCannotBeNull": "deploymentName cannot be null or undefined and it must be of type string.", | ||
"CredentialsCannotBeNull": "'credentials' cannot be null.", | ||
"SubscriptionIdCannotBeNull": "'subscriptionId' cannot be null.", | ||
"InvalidResponseLongRunningOperation": "Invalid response received for fetching status of a long running operation.", | ||
"TimeoutWhileWaiting": "Timed out while waiting", | ||
"ResourceGroupCannotBeNull": "resourceGroupName cannot be null or undefined and it must be of type string.", | ||
"ResourceGroupExceededLength": "\"resourceGroupName\" should satisfy the constraint - \"MaxLength\": 90", | ||
"ResourceGroupDeceededLength": "\"resourceGroupName\" should satisfy the constraint - \"MinLength\": 1", | ||
"ResourceGroupDoesntMatchPattern": "\"resourceGroupName\" should satisfy the constraint - \"Pattern\": /^[-\\w\\._\\(\\)]+$/" | ||
} | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
{ | ||
"name": "azure-arm-rest", | ||
"version": "1.0.0", | ||
"description": "Common Lib for Azure ARM REST apis", | ||
"repository": { | ||
"type": "git", | ||
"url": "git+ssh://[email protected]/Microsoft/vsts-tasks.git" | ||
}, | ||
"author": "Microsoft Corporation", | ||
"license": "MIT", | ||
"bugs": { | ||
"url": "https://github.com/Microsoft/vsts-tasks/issues" | ||
}, | ||
"homepage": "https://github.com/Microsoft/vsts-tasks#readme", | ||
"dependencies": { | ||
"q": "1.4.1", | ||
"vso-node-api": "6.0.1-preview", | ||
"vsts-task-lib": "^0.9.20" | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"compilerOptions": { | ||
"module": "commonjs", | ||
"target": "es6", | ||
"declaration": true | ||
} | ||
} |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
{ | ||
"globalDependencies": { | ||
"mocha": "registry:dt/mocha#2.2.5+20160720003353", | ||
"node": "registry:dt/node#6.0.0+20160920093002", | ||
"q": "registry:dt/q#0.0.0+20160613154756" | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the messages which are meant for the library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned below, I will wait for resolution on module.json before rremoving strings from here. Will take it separately.