Move azure-arm-rest to Common directory #4527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bishal-pdMSFT
requested review from
thesattiraju and
sachinma
and removed request for
thesattiraju
| @@ -14,7 +14,7 @@ | |||
| "version": { | |||
| "Major": 2, | |||
| "Minor": 1, | |||
| "Patch": 6 | |||
| "Patch": 7 | |||
| }, | |||
| "demands": [], | |||
| "minimumAgentVersion": "2.0.0", | |||
There was a problem hiding this comment.
Remove the messages which are meant for the library
There was a problem hiding this comment.
As mentioned below, I will wait for resolution on module.json before rremoving strings from here. Will take it separately.
| "loc.messages.ResourceGroupExceededLength": "\"resourceGroupName\" should satisfy the constraint - \"MaxLength\": 90", | ||
| "loc.messages.ResourceGroupDeceededLength": "\"resourceGroupName\" should satisfy the constraint - \"MinLength\": 1", | ||
| "loc.messages.ResourceGroupDoesntMatchPattern": "\"resourceGroupName\" should satisfy the constraint - \"Pattern\": /^[-\\w\\._\\(\\)]+$/" | ||
| } |
There was a problem hiding this comment.
do verify if these strings are getting picked or not, if there are duplicate keys.
There was a problem hiding this comment.
As per other common module, this should work. I will test after removing strings from task.
There was a problem hiding this comment.
This does not work with module.json. I have sent a mail to Eric/Bryan asking for any work-around. In the meanwhile I will not remove these strings from task.json.
thesattiraju
approved these changes
Jun 14, 2017
bishal-pdMSFT
added a commit
that referenced
this pull request
Jun 14, 2017
Revert "Merge pull request #4527 from Microsoft/users/biprasad/MoveAz…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.