VSTestPlusPlus with UI #3525
VSTestPlusPlus with UI #3525
Conversation
|
Hi @RanjanarMS, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
Tasks/VsTest/task.json
Outdated
| "Agent", | ||
| "MachineGroup" | ||
| ], | ||
| "author": "Microsoft Corporation", | ||
| "version": { | ||
| "Major": 2, | ||
| "Minor": 0, | ||
| "Patch": 11 | ||
| "Patch": 100 |
There was a problem hiding this comment.
100 [](start = 17, length = 3)
any reason why 100?
| }, | ||
| "demands": [ | ||
| "vstest" | ||
| ], | ||
| "preview": "true", | ||
| "releaseNotes": "<ul><li><b>Test Impact Analysis:</b> Automatically select and run only the tests needed to validate the code change.</li><li>Support for minimatch patterns for specifying test assemblies.</li></ul>", | ||
| "releaseNotes" : "Adding the functionality to run distributed test with release phases.", |
There was a problem hiding this comment.
releaseNotes" : "Adding the functionality to run distributed test with release phases [](start = 5, length = 85)
why remove old release notes? can you check with Prachi here
There was a problem hiding this comment.
Will sync up with Prachi and put the right text in next iteration.
Tasks/VsTest/task.json
Outdated
| @@ -1,198 +1,260 @@ | |||
| { | |||
| "id": "EF087383-EE5E-42C7-9A53-AB56C98420F9", | |||
| "name": "VSTest", | |||
| "friendlyName": "Visual Studio Test", | |||
| "friendlyName": "Visual Studio Test Plus Plus", | |||
There was a problem hiding this comment.
Plus Plus [](start = 40, length = 9)
why change this?
Tasks/VsTest/task.json
Outdated
| "description": "Run tests with Visual Studio test runner", | ||
| "helpMarkDown": "[More Information](https://go.microsoft.com/fwlink/?LinkId=835764)", | ||
| "category": "Test", | ||
| "visibility": [ | ||
| "Build", | ||
| "Release" | ||
| ], | ||
| "runsOn": [ | ||
| "runsOn": [ | ||
| "Agent", | ||
| "MachineGroup" | ||
| ], | ||
| "author": "Microsoft Corporation", |
There was a problem hiding this comment.
can we test upgrade scenario by creating a build definition with 2.11 task and then uploading this task and check if we queue build things are fine
Tasks/VsTest/task.json
Outdated
| { | ||
| "name": "vstestLocationMethod", |
There was a problem hiding this comment.
is there a way we can make sure thta definition which have selected this option can fall back to latest option automatically. so as we dont break their builds?
Tasks/VsTest/task.json
Outdated
| "visibleRule": "testSelector = testAssemblies && runOnlyImpactedTests = true" | ||
| }, | ||
| { | ||
| "name": "testPlatform", |
There was a problem hiding this comment.
testPlatform [](start = 20, length = 12)
why change the name? wont it break existing build def?
Tasks/VsTest/distributedTest.ts
Outdated
| } | ||
| } | ||
|
|
||
| private async createAgent(retries: number) { |
There was a problem hiding this comment.
should we refactor agent command and run command in separate classes / files?
There was a problem hiding this comment.
Moved TestAgent out.. And helper functions out
Tasks/VsTest/task.json
Outdated
| "Agent", | ||
| "MachineGroup" | ||
| ], | ||
| "author": "Microsoft Corporation", | ||
| "version": { | ||
| "Major": 2, | ||
| "Minor": 0, | ||
| "Patch": 11 | ||
| "Patch": 100 |
There was a problem hiding this comment.
100 [](start = 17, length = 3)
i still see this as 100
Tasks/VsTest/task.json
Outdated
| }, | ||
| { | ||
| "name": "vsTestVersion", |
There was a problem hiding this comment.
vsTestVersion [](start = 21, length = 13)
if we rename this option people will always get vs 2015. specially when they are using test impact using 2017
|
|
Users/siddhap/2015vstia
Users/kavipriya/settings
No description provided.