Users/siddhap/2015vstia #3539
Merged
Users/siddhap/2015vstia #3539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaadhina
reviewed
Feb 6, 2017
Tasks/VsTest/task.json
Outdated
| @@ -322,7 +322,7 @@ | |||
| "NoMatchingTestAssemblies": "No test assemblies found matching the pattern: %s.", | |||
| "VstestNotFound": "Vstest of version %d is not found. Try again with a visual studio version that exists on your build agent machine.", | |||
| "VstestFailed": "Vstest failed with error. Check logs for failures. There might be failed tests.", | |||
| "VstestTIANotSupported": "Install Visual Studio version 15.0.25807 or higher to run Test Impact Analysis.", | |||
| "VstestTIANotSupported": "Install Visual Studio 14 update 3 or 15 RC or above to run Test Impact Analysis.", | |||
There was a problem hiding this comment.
Will user understand 14/15, should we say 2015 2017?
kaadhina
reviewed
Feb 6, 2017
Tasks/VsTest/vstest.ts
Outdated
| if (tiaConfig.tiaEnabled && (vsTestVersionForTIA === null || (vsTestVersionForTIA[0] < 15 || (vsTestVersionForTIA[0] === 15 && vsTestVersionForTIA[1] === 0 && vsTestVersionForTIA[2] < 25727)))) { | ||
| if (tiaConfig.tiaEnabled && (vsTestVersionForTIA === null || | ||
| (vsTestVersionForTIA[0] < 14 || | ||
| (vsTestVersionForTIA[0] === 15 && vsTestVersionForTIA[1] === 0 && vsTestVersionForTIA[2] < 25727) || |
There was a problem hiding this comment.
We have packaged both the collector and vstest.console, what other changes which is not in < vs14 u3? #Closed
kaadhina
reviewed
Feb 6, 2017
Tasks/VsTest/vstest.ts
Outdated
| @@ -493,6 +498,11 @@ function getVstestTestsList(vsVersion: number): Q.Promise<string> { | |||
| } | |||
|
|
|||
| let vstest = tl.tool(vsVersionDetails.location); | |||
|
|
|||
| if(vsVersion === 14) { | |||
| let vsTestPath = path.join(__dirname, "TestSelector/14.0/vstest.console.exe") // Use private vstest as the changes to discover tests are not there in update3 | |||
There was a problem hiding this comment.
We will use probing path for assembly redirections? Have we tested this? Remember facing some issue last time while trying this. #Closed
kaadhina
approved these changes
Feb 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for vs 2015 when TIA is on.