Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update powershell sanitizer regex #19028

Merged

Conversation

KonstantinTyukalov
Copy link
Contributor

@KonstantinTyukalov KonstantinTyukalov commented Sep 27, 2023

Task name: AzureFileCopyV*, WindowsMachineFileCopyV*

Description: Fix regex to allow escaping in powershell + add more symbols to allowlist.

Changelog:

  • Update sanitizer regex: changed esc symbol to ` instead of \
  • Added / : . * , + ~ ? % symbols sanitizer allowlist
  • Update sanitizer tests
  • Added Protect-ScriptArguments function tests
  • Added support to run tests in common modules separately

Documentation changes required: N

Added unit tests: Y

Attached related issue: #19017

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected - unit tests + e2e canary

make-util.js Outdated Show resolved Hide resolved
@KonstantinTyukalov KonstantinTyukalov marked this pull request as ready for review September 27, 2023 19:11
@KonstantinTyukalov KonstantinTyukalov requested review from a user and LeftTwixWand September 27, 2023 19:12
Co-authored-by: Vladyslav Horbachov <[email protected]>
@KonstantinTyukalov KonstantinTyukalov force-pushed the users/KonstantinTyukalov/Update_sanitizer_regex branch from f5f8b84 to 018187f Compare October 2, 2023 14:24
@KonstantinTyukalov KonstantinTyukalov merged commit 83229f4 into master Oct 2, 2023
8 checks passed
@KonstantinTyukalov KonstantinTyukalov deleted the users/KonstantinTyukalov/Update_sanitizer_regex branch October 2, 2023 20:28
LeftTwixWand added a commit to microsoft/azure-pipelines-extensions that referenced this pull request Oct 3, 2023
LeftTwixWand added a commit to microsoft/azure-pipelines-extensions that referenced this pull request Oct 3, 2023
* Updated regex to allow more characters

Copy of microsoft/azure-pipelines-tasks#19028

* Bump extension and tasks versions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants