Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update powershell sanitizer regex #1199

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Conversation

LeftTwixWand
Copy link
Contributor

@LeftTwixWand LeftTwixWand commented Oct 3, 2023

Extension name: IIS Web App Deployment Using WinRM

Task name:

  • IISWebAppDeployV1
  • IISWebAppDeployV2
  • IISWebAppMgmtV1
  • IISWebAppMgmtV2
  • IISWebAppMgmtV3
  • SqlDacpacDeployV1
  • SqlDacpacDeployV2

Description:
Copy of microsoft/azure-pipelines-tasks#19028 which extends sanitizer with more allowed characters.

Documentation changes required: N

Added unit tests: Y

Checklist:

  • Task version was bumped
  • Checked that applied changes work as expected

Changelog:

  • Update sanitizer regex: changed esc symbol to ` instead of \
  • Added / : . * , + ~ ? % symbols sanitizer allowlist
  • Update sanitizer tests
  • Added Protect-ScriptArguments function tests
  • Added support to run tests in common modules separately

Attached related issue: microsoft/azure-pipelines-tasks#19017

@LeftTwixWand LeftTwixWand requested a review from a user October 3, 2023 09:31
@LeftTwixWand LeftTwixWand merged commit 6a88be6 into master Oct 3, 2023
2 checks passed
@LeftTwixWand LeftTwixWand deleted the update-sanitizer-regex branch October 3, 2023 13:54
@LeftTwixWand LeftTwixWand self-assigned this Oct 4, 2023
@LeftTwixWand LeftTwixWand added enhancement Area: IISWebAppDeploy Changes related to IISWebAppDeploy extension labels Oct 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: IISWebAppDeploy Changes related to IISWebAppDeploy extension enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant