Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched DownloadBuildArtifactV0 to agent plugin. Aligned DownloadBuildArtifactV1 task with V0 #15244

Merged
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -38,34 +38,5 @@
"loc.input.label.retryDownloadCount": "Retry count",
"loc.input.help.retryDownloadCount": "Optional number of times to retry downloading a build artifact if the download fails.",
"loc.input.label.extractTars": "Extract all files that are stored inside tar archives",
"loc.input.help.extractTars": "Enable this option to extract all downloaded files that have .tar extension. This is helpful because you need to pack your artifact files into tar if you want to preserve Unix file permissions. Enabling `StoreAsTar` option in PublishBuildArtifacts task will store artifacts as .tar files automatically.",
"loc.messages.DownloadArtifacts": "Downloading artifact %s from: %s",
"loc.messages.DownloadingArtifactsForBuild": "Downloading artifacts for build: %s",
"loc.messages.LinkedArtifactCount": "Linked artifacts count: %s",
"loc.messages.ExtractionFailed": "Failed to extract package with error %s",
"loc.messages.FileContainerInvalidArtifactData": "Invalid file container artifact. Resource data must be in the format #/{container id}/path",
"loc.messages.UnsupportedArtifactType": "Unsupported artifact type: %s",
"loc.messages.BuildNotFound": "Build with ID %s not found",
"loc.messages.BuildArtifactNotFound": "Artifact %s not found for build %s. Please ensure you have published artifacts in any previous phases of the current build.",
"loc.messages.NoArtifactsFound": "No artifacts found for build %s",
"loc.messages.BuildIdBuildDefinitionMismatch": "Build with ID %s not found for build pipeline ID %s",
"loc.messages.ArtifactsSuccessfullyDownloaded": "Successfully downloaded artifacts to %s",
"loc.messages.RetryingOperation": "Error: in %s, so retrying => retries pending : %s",
"loc.messages.OperationFailed": "Failed in %s with error: %s",
"loc.messages.ArtifactNameDirectoryNotFound": "Directory '%s' does not exist. Falling back to parent directory: %s",
"loc.messages.LatestBuildFound": "Latest build found: %s",
"loc.messages.LatestBuildNotFound": "Latest build not found",
"loc.messages.LatestBuildFromBranchNotFound": "Latest build from branch %s not found",
"loc.messages.DownloadingContainerResource": "Downloading items from container resource %s",
"loc.messages.DefinitionNameMatchFound": "Definition Name %s resolved to id %d",
"loc.messages.InvalidBuildDefinitionName": "Definition name %s didn't correspond to a valid definition",
"loc.messages.UnresolvedDefinitionId": "Could not resolve build definition id",
"loc.messages.BeginArtifactItemsIntegrityCheck": "Starting artifact items integrity check",
"loc.messages.CorruptedArtifactItemsList": "The following items are not passed integrity check:",
"loc.messages.IntegrityCheckNotPassed": "Artifact items integrity check failed",
"loc.messages.IntegrityCheckPassed": "Artifact items integrity check successfully finished",
"loc.messages.TarExtractionNotSupportedInWindows": "Tar extraction is not supported on Windows",
"loc.messages.NoTarsFound": "No tar archives were found to extract",
"loc.messages.CleaningDestinationFolder": "Cleaning destination folder: %s",
"loc.messages.NoFolderToClean": "Specified cleaning folder was not found. Nothing to clean"
"loc.input.help.extractTars": "Enable this option to extract all downloaded files that have .tar extension. This is helpful because you need to pack your artifact files into tar if you want to preserve Unix file permissions. Enabling `StoreAsTar` option in PublishBuildArtifacts task will store artifacts as .tar files automatically."
}
40 changes: 5 additions & 35 deletions Tasks/DownloadBuildArtifactsV0/task.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"author": "Microsoft Corporation",
"version": {
"Major": 0,
"Minor": 190,
"Minor": 193,
"Patch": 0
},
"groups": [
Expand All @@ -19,6 +19,7 @@
"isExpanded": false
}
],
"minimumAgentVersion": "2.191.1",
"demands": [],
"inputs": [
{
Expand Down Expand Up @@ -263,42 +264,11 @@
],
"instanceNameFormat": "Download Build Artifacts",
"execution": {
"Node10": {
"target": "main.js",
"argumentFormat": ""
"AgentPlugin": {
"target": "Agent.Plugins.BuildArtifacts.DownloadBuildArtifactTaskV1_0_0, Agent.Plugins"
}
},
"messages": {
"DownloadArtifacts": "Downloading artifact %s from: %s",
"DownloadingArtifactsForBuild": "Downloading artifacts for build: %s",
"LinkedArtifactCount": "Linked artifacts count: %s",
"ExtractionFailed": "Failed to extract package with error %s",
"FileContainerInvalidArtifactData": "Invalid file container artifact. Resource data must be in the format #/{container id}/path",
"UnsupportedArtifactType": "Unsupported artifact type: %s",
"BuildNotFound": "Build with ID %s not found",
"BuildArtifactNotFound": "Artifact %s not found for build %s. Please ensure you have published artifacts in any previous phases of the current build.",
"NoArtifactsFound": "No artifacts found for build %s",
"BuildIdBuildDefinitionMismatch": "Build with ID %s not found for build pipeline ID %s",
"ArtifactsSuccessfullyDownloaded": "Successfully downloaded artifacts to %s",
"RetryingOperation": "Error: in %s, so retrying => retries pending : %s",
"OperationFailed": "Failed in %s with error: %s",
"ArtifactNameDirectoryNotFound": "Directory '%s' does not exist. Falling back to parent directory: %s",
"LatestBuildFound": "Latest build found: %s",
"LatestBuildNotFound": "Latest build not found",
"LatestBuildFromBranchNotFound": "Latest build from branch %s not found",
"DownloadingContainerResource": "Downloading items from container resource %s",
"DefinitionNameMatchFound": "Definition Name %s resolved to id %d",
"InvalidBuildDefinitionName": "Definition name %s didn't correspond to a valid definition",
"UnresolvedDefinitionId": "Could not resolve build definition id",
"BeginArtifactItemsIntegrityCheck": "Starting artifact items integrity check",
"CorruptedArtifactItemsList": "The following items are not passed integrity check:",
"IntegrityCheckNotPassed": "Artifact items integrity check failed",
"IntegrityCheckPassed": "Artifact items integrity check successfully finished",
"TarExtractionNotSupportedInWindows": "Tar extraction is not supported on Windows",
"NoTarsFound": "No tar archives were found to extract",
"CleaningDestinationFolder": "Cleaning destination folder: %s",
"NoFolderToClean": "Specified cleaning folder was not found. Nothing to clean"
},
"messages": {},
"outputVariables": [
{
"name": "BuildNumber",
Expand Down
40 changes: 5 additions & 35 deletions Tasks/DownloadBuildArtifactsV0/task.loc.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"author": "Microsoft Corporation",
"version": {
"Major": 0,
"Minor": 190,
"Minor": 193,
"Patch": 0
},
"groups": [
Expand All @@ -19,6 +19,7 @@
"isExpanded": false
}
],
"minimumAgentVersion": "2.191.1",
"demands": [],
"inputs": [
{
Expand Down Expand Up @@ -263,42 +264,11 @@
],
"instanceNameFormat": "ms-resource:loc.instanceNameFormat",
"execution": {
"Node10": {
"target": "main.js",
"argumentFormat": ""
"AgentPlugin": {
"target": "Agent.Plugins.BuildArtifacts.DownloadBuildArtifactTaskV1_0_0, Agent.Plugins"
}
},
"messages": {
"DownloadArtifacts": "ms-resource:loc.messages.DownloadArtifacts",
"DownloadingArtifactsForBuild": "ms-resource:loc.messages.DownloadingArtifactsForBuild",
"LinkedArtifactCount": "ms-resource:loc.messages.LinkedArtifactCount",
"ExtractionFailed": "ms-resource:loc.messages.ExtractionFailed",
"FileContainerInvalidArtifactData": "ms-resource:loc.messages.FileContainerInvalidArtifactData",
"UnsupportedArtifactType": "ms-resource:loc.messages.UnsupportedArtifactType",
"BuildNotFound": "ms-resource:loc.messages.BuildNotFound",
"BuildArtifactNotFound": "ms-resource:loc.messages.BuildArtifactNotFound",
"NoArtifactsFound": "ms-resource:loc.messages.NoArtifactsFound",
"BuildIdBuildDefinitionMismatch": "ms-resource:loc.messages.BuildIdBuildDefinitionMismatch",
"ArtifactsSuccessfullyDownloaded": "ms-resource:loc.messages.ArtifactsSuccessfullyDownloaded",
"RetryingOperation": "ms-resource:loc.messages.RetryingOperation",
"OperationFailed": "ms-resource:loc.messages.OperationFailed",
"ArtifactNameDirectoryNotFound": "ms-resource:loc.messages.ArtifactNameDirectoryNotFound",
"LatestBuildFound": "ms-resource:loc.messages.LatestBuildFound",
"LatestBuildNotFound": "ms-resource:loc.messages.LatestBuildNotFound",
"LatestBuildFromBranchNotFound": "ms-resource:loc.messages.LatestBuildFromBranchNotFound",
"DownloadingContainerResource": "ms-resource:loc.messages.DownloadingContainerResource",
"DefinitionNameMatchFound": "ms-resource:loc.messages.DefinitionNameMatchFound",
"InvalidBuildDefinitionName": "ms-resource:loc.messages.InvalidBuildDefinitionName",
"UnresolvedDefinitionId": "ms-resource:loc.messages.UnresolvedDefinitionId",
"BeginArtifactItemsIntegrityCheck": "ms-resource:loc.messages.BeginArtifactItemsIntegrityCheck",
"CorruptedArtifactItemsList": "ms-resource:loc.messages.CorruptedArtifactItemsList",
"IntegrityCheckNotPassed": "ms-resource:loc.messages.IntegrityCheckNotPassed",
"IntegrityCheckPassed": "ms-resource:loc.messages.IntegrityCheckPassed",
"TarExtractionNotSupportedInWindows": "ms-resource:loc.messages.TarExtractionNotSupportedInWindows",
"NoTarsFound": "ms-resource:loc.messages.NoTarsFound",
"CleaningDestinationFolder": "ms-resource:loc.messages.CleaningDestinationFolder",
"NoFolderToClean": "ms-resource:loc.messages.NoFolderToClean"
},
"messages": {},
"outputVariables": [
{
"name": "BuildNumber",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,14 @@
"loc.input.help.itemPattern": "Specify files to be downloaded as multi line minimatch pattern. [More Information](https://aka.ms/minimatchexamples) <p>The default pattern (\\*\\*) will download all files across all artifacts in the build if \"Specific files\" option is selected. To download all files within artifact drop use drop/**.</p>",
"loc.input.label.downloadPath": "Destination directory",
"loc.input.help.downloadPath": "Path on the agent machine where the artifacts will be downloaded",
"loc.input.label.cleanDestinationFolder": "Clean destination folder",
"loc.input.help.cleanDestinationFolder": "Delete all existing files in destination folder before artifact download",
"loc.input.label.parallelizationLimit": "Parallelization limit",
"loc.input.help.parallelizationLimit": "Number of files to download simultaneously",
"loc.input.label.checkDownloadedFiles": "Check downloaded files",
"loc.input.help.checkDownloadedFiles": "If checked, this build task will check that all files are fully downloaded.",
"loc.input.label.retryDownloadCount": "Retry count",
"loc.input.help.retryDownloadCount": "Optional number of times to retry downloading a build artifact if the download fails."
"loc.input.help.retryDownloadCount": "Optional number of times to retry downloading a build artifact if the download fails.",
"loc.input.label.extractTars": "Extract all files that are stored inside tar archives",
"loc.input.help.extractTars": "Enable this option to extract all downloaded files that have .tar extension. This is helpful because you need to pack your artifact files into tar if you want to preserve Unix file permissions. Enabling `StoreAsTar` option in PublishBuildArtifacts task will store artifacts as .tar files automatically."
}
19 changes: 17 additions & 2 deletions Tasks/DownloadBuildArtifactsV1/task.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"author": "Microsoft Corporation",
"version": {
"Major": 1,
"Minor": 192,
"Minor": 193,
"Patch": 0
},
"groups": [
Expand All @@ -19,7 +19,7 @@
"isExpanded": false
}
],
"minimumAgentVersion": "2.188.2",
"minimumAgentVersion": "2.191.1",
"demands": [],
"inputs": [
{
Expand Down Expand Up @@ -171,6 +171,13 @@
"required": true,
"helpMarkDown": "Path on the agent machine where the artifacts will be downloaded"
},
{
"name": "cleanDestinationFolder",
"type": "boolean",
"label": "Clean destination folder",
"defaultValue": false,
"helpMarkDown": "Delete all existing files in destination folder before artifact download"
},
{
"name": "parallelizationLimit",
"type": "string",
Expand All @@ -197,6 +204,14 @@
"groupName": "advanced",
"required": false,
"helpMarkDown": "Optional number of times to retry downloading a build artifact if the download fails."
},
{
"name": "extractTars",
anatolybolshakov marked this conversation as resolved.
Show resolved Hide resolved
"type": "boolean",
"label": "Extract all files that are stored inside tar archives",
"groupName": "advanced",
"required": false,
"helpMarkDown": "Enable this option to extract all downloaded files that have .tar extension. This is helpful because you need to pack your artifact files into tar if you want to preserve Unix file permissions. Enabling `StoreAsTar` option in PublishBuildArtifacts task will store artifacts as .tar files automatically."
}
],
"dataSourceBindings": [
Expand Down
19 changes: 17 additions & 2 deletions Tasks/DownloadBuildArtifactsV1/task.loc.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"author": "Microsoft Corporation",
"version": {
"Major": 1,
"Minor": 192,
"Minor": 193,
"Patch": 0
},
"groups": [
Expand All @@ -19,7 +19,7 @@
"isExpanded": false
}
],
"minimumAgentVersion": "2.188.2",
"minimumAgentVersion": "2.191.1",
"demands": [],
"inputs": [
{
Expand Down Expand Up @@ -171,6 +171,13 @@
"required": true,
"helpMarkDown": "ms-resource:loc.input.help.downloadPath"
},
{
"name": "cleanDestinationFolder",
"type": "boolean",
"label": "ms-resource:loc.input.label.cleanDestinationFolder",
"defaultValue": false,
"helpMarkDown": "ms-resource:loc.input.help.cleanDestinationFolder"
},
{
"name": "parallelizationLimit",
"type": "string",
Expand All @@ -197,6 +204,14 @@
"groupName": "advanced",
"required": false,
"helpMarkDown": "ms-resource:loc.input.help.retryDownloadCount"
},
{
"name": "extractTars",
"type": "boolean",
"label": "ms-resource:loc.input.label.extractTars",
"groupName": "advanced",
"required": false,
"helpMarkDown": "ms-resource:loc.input.help.extractTars"
}
],
"dataSourceBindings": [
Expand Down