Switched DownloadBuildArtifactV0 to agent plugin. Aligned DownloadBuildArtifactV1 task with V0

[anatolybolshakov]

Task name: DownloadBuildArtifactV1, DownloadBuildArtifactV0

Description: switched DownloadBuildArtifactV0 to agent plugin. Aligned inputs for DownloadBuildArtifactV1 and DownloadBuildArtifactV0. Bumped minimum agent version for these tasks to 2.191.1 - to align with plugin changes.

Documentation changes required: Y (in progress)

Added unit tests: N

Attached related issue: N

Checklist:

• Task version was bumped - please check instruction how to do it
• Checked that applied changes work as expected - tested for V0/V1 tasks with simple scenarios

[EzzhevNikita]

I think we should remove ts implementation of the task from DownloadBuildArtifactsV0, since it won't be used in fact. Do you have any concerns about it?

[anatolybolshakov]

I think we should remove ts implementation of the task from DownloadBuildArtifactsV0, since it won't be used in fact. Do you have any concerns about it?

Yes make sense, let me update also

[EzzhevNikita]

LGTM! Tested these changes manually found no issues, everything work as expected

[jacqueskang]

Despite that this change has been reverted, I would like to report that the DownloadBuildArtifact v0.193.0 is breaking our deployment pipeline since 2 weeks ago.

Our deployment pool agent is installed in CentOS 7 host. Outbound communications are protected by corporate proxy.

The error message we got are pasted below.

It might be related to this issue?

2021-10-26T07:38:34.4029232Z ##[debug]Evaluating condition for step: 'Download artifact - infrastructure-plant - infrastructure-plant'
2021-10-26T07:38:34.4031591Z ##[debug]Evaluating: succeeded()
2021-10-26T07:38:34.4032430Z ##[debug]Evaluating succeeded:
2021-10-26T07:38:34.4034017Z ##[debug]=> True
2021-10-26T07:38:34.4034860Z ##[debug]Result: True
2021-10-26T07:38:34.4035707Z ##[section]Starting: Download artifact - infrastructure-plant - infrastructure-plant
2021-10-26T07:38:34.4099413Z ==============================================================================
2021-10-26T07:38:34.4099942Z Task         : Download build artifacts
2021-10-26T07:38:34.4100325Z Description  : Download files that were saved as artifacts of a completed build
2021-10-26T07:38:34.4100658Z Version      : 0.193.0
2021-10-26T07:38:34.4100983Z Author       : Microsoft Corporation
2021-10-26T07:38:34.4101388Z Help         : https://docs.microsoft.com/azure/devops/pipelines/tasks/utility/download-build-artifacts
2021-10-26T07:38:34.4101830Z ==============================================================================
2021-10-26T07:38:34.7993260Z Download from the specified build: #42333
2021-10-26T07:38:34.8045159Z ##[debug]Processed: ##vso[task.setvariable variable=BuildNumber;issecret=False;]42333
2021-10-26T07:38:34.8048703Z Download artifact to: /home/AIVIadmin/azagent/_work/r1/a/infrastructure-plant/
2021-10-26T07:38:36.8069269Z ##[error]GSSAPI operation failed with error - Unspecified GSS failure.  Minor code may provide more information (SPNEGO cannot find mechanisms to negotiate).
2021-10-26T07:38:36.8082222Z ##[debug]Processed: ##vso[task.logissue type=error;]GSSAPI operation failed with error - Unspecified GSS failure.  Minor code may provide more information (SPNEGO cannot find mechanisms to negotiate).
2021-10-26T07:38:36.8095475Z ##[debug]Processed: ##vso[task.complete result=Failed;]
2021-10-26T07:38:36.8373323Z ##[debug]   at System.Net.NTAuthentication.GetOutgoingBlob(Byte[] incomingBlob, Boolean throwOnError, SecurityStatusPal& statusCode)
   at System.Net.NTAuthentication.GetOutgoingBlob(String incomingBlob)
   at System.Net.Http.AuthenticationHelper.SendWithNtAuthAsync(HttpRequestMessage request, Uri authUri, ICredentials credentials, Boolean isProxyAuth, HttpConnection connection, HttpConnectionPool connectionPool, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.SendWithNtConnectionAuthAsync(HttpConnection connection, HttpRequestMessage request, Boolean doRequestAuth, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.SendWithRetryAsync(HttpRequestMessage request, Boolean doRequestAuth, CancellationToken cancellationToken)
   at System.Net.Http.AuthenticationHelper.SendWithAuthAsync(HttpRequestMessage request, Uri authUri, ICredentials credentials, Boolean preAuthenticate, Boolean isProxyAuth, Boolean doRequestAuth, HttpConnectionPool pool, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.EstablishProxyTunnel(HttpRequestHeaders headers, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.ConnectAsync(HttpRequestMessage request, Boolean allowHttp2, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.CreateHttp11ConnectionAsync(HttpRequestMessage request, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.GetHttpConnectionAsync(HttpRequestMessage request, CancellationToken cancellationToken)
   at System.Net.Http.HttpConnectionPool.SendWithRetryAsync(HttpRequestMessage request, Boolean doRequestAuth, CancellationToken cancellationToken)
   at System.Net.Http.AuthenticationHelper.SendWithAuthAsync(HttpRequestMessage request, Uri authUri, ICredentials credentials, Boolean preAuthenticate, Boolean isProxyAuth, Boolean doRequestAuth, HttpConnectionPool pool, CancellationToken cancellationToken)
   at System.Net.Http.DecompressionHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
   at Microsoft.VisualStudio.Services.Common.VssHttpMessageHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
   at Microsoft.VisualStudio.Services.Common.VssHttpRetryMessageHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
   at System.Net.Http.HttpClient.FinishSendAsyncBuffered(Task`1 sendTask, HttpRequestMessage request, CancellationTokenSource cts, Boolean disposeCts)
   at Microsoft.VisualStudio.Services.WebApi.VssHttpClientBase.SendAsync(HttpRequestMessage message, HttpCompletionOption completionOption, Object userState, CancellationToken cancellationToken)
   at Microsoft.VisualStudio.Services.WebApi.VssHttpClientBase.SendAsync[T](HttpRequestMessage message, Object userState, CancellationToken cancellationToken)
   at Microsoft.VisualStudio.Services.Location.Client.LocationHttpClient.GetConnectionDataAsync(ConnectOptions connectOptions, Int64 lastChangeId, CancellationToken cancellationToken, Object userState)
   at Microsoft.VisualStudio.Services.WebApi.Location.VssServerDataProvider.GetConnectionDataAsync(ConnectOptions connectOptions, Int32 lastChangeId, CancellationToken cancellationToken)
   at Microsoft.VisualStudio.Services.WebApi.Location.VssServerDataProvider.ConnectAsync(ConnectOptions connectOptions, CancellationToken cancellationToken)
   at Microsoft.VisualStudio.Services.WebApi.Location.LocationService.CreateDataProviderAsync(String location, CancellationToken cancellationToken)
   at Microsoft.VisualStudio.Services.WebApi.Location.LocationService.ResolveLocationDataAsync(Guid locationAreaIdentifier, CancellationToken cancellationToken)
   at Microsoft.VisualStudio.Services.WebApi.Location.LocationService.ResolveLocationDataAsync(Guid locationAreaIdentifier, CancellationToken cancellationToken)
   at Microsoft.VisualStudio.Services.WebApi.Location.LocationService.GetLocationDataAsync(Guid locationAreaIdentifier, CancellationToken cancellationToken)
   at Microsoft.VisualStudio.Services.WebApi.VssConnection.GetClientInstanceAsync(Type managedType, Guid serviceIdentifier, CancellationToken cancellationToken, VssHttpRequestSettings settings, DelegatingHandler[] handlers)
   at Microsoft.VisualStudio.Services.WebApi.VssConnection.GetClientServiceImplAsync(Type requestedType, Guid serviceIdentifier, Func`4 getInstanceAsync, CancellationToken cancellationToken)
   at Microsoft.VisualStudio.Services.WebApi.VssConnection.GetClientAsync[T](CancellationToken cancellationToken)
   at Microsoft.VisualStudio.Services.WebApi.TaskExtensions.SyncResult[T](Task`1 task)
   at Microsoft.VisualStudio.Services.WebApi.VssConnection.GetClient[T]()
   at Agent.Plugins.BuildServer..ctor(VssConnection connection)
   at Agent.Plugins.PipelineArtifactServer.DownloadAsyncV2(AgentTaskPluginExecutionContext context, ArtifactDownloadParameters downloadParameters, DownloadOptions downloadOptions, CancellationToken cancellationToken)
   at Agent.Plugins.BuildArtifacts.DownloadBuildArtifactTaskV1_0_0.ProcessCommandInternalAsync(AgentTaskPluginExecutionContext context, CancellationToken token)
   at Agent.PluginHost.Program.Main(String[] args)
2021-10-26T07:38:36.8458876Z ##[section]Finishing: Download artifact - infrastructure-plant - infrastructure-plant