Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MavenV2, MavenV3]: Fixed bug when task succeeds on tests failure #14658

Merged
merged 13 commits into from
Apr 1, 2021
Merged

[MavenV2, MavenV3]: Fixed bug when task succeeds on tests failure #14658

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
b77de40
fixed for maven v3, updated minor ver
Mar 25, 2021
533889f
Fixed for maven v2, updated minor ver
Mar 25, 2021
017826a
revert fmt for V3
Mar 25, 2021
3abd11e
revert fmt for v2, upd v3
Mar 25, 2021
07c5d94
Merge branch 'master' into maven-14514
Mar 25, 2021
d333186
Merge branch 'master' into maven-14514
Mar 26, 2021
62ac552
Merge branch 'master' into maven-14514
Mar 26, 2021
e1ce92c
Merge branch 'master' into maven-14514
Mar 30, 2021
8665fa6
rolledback find options for test publish
Mar 30, 2021
070754d
added input for v2
Mar 31, 2021
d117250
added input for v3
Mar 31, 2021
279eb70
add dependency for input
Apr 1, 2021
dcddcdb
Merge branch 'master' into maven-14514
Apr 1, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions Tasks/MavenV2/maventask.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,6 +286,11 @@ async function execBuild() {
});

// Do not force an exit as publishing results is async and it won't have finished
})
.fail(function (err) {
// Set task failure if get exception at step 5
console.error(err.message);
anatolybolshakov marked this conversation as resolved.
Show resolved Hide resolved
tl.setResult(tl.TaskResult.Failed, "Build failed.");
});
}

Expand Down Expand Up @@ -336,9 +341,11 @@ function publishJUnitTestResults(testResultsFiles: string) {
tl.debug('Pattern found in testResultsFiles parameter');
var buildFolder = tl.getVariable('System.DefaultWorkingDirectory');
tl.debug(`buildFolder=${buildFolder}`);
matchingJUnitResultFiles = tl.findMatch(buildFolder, testResultsFiles, null, {
matchBase: true
});
matchingJUnitResultFiles = tl.findMatch(buildFolder, testResultsFiles, {
allowBrokenSymbolicLinks: true,
anatolybolshakov marked this conversation as resolved.
Show resolved Hide resolved
followSpecifiedSymbolicLink: true,
followSymbolicLinks: true,
}, { matchBase: true });
}
else {
tl.debug('No pattern found in testResultsFiles parameter');
Expand Down
2 changes: 1 addition & 1 deletion Tasks/MavenV2/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"author": "Microsoft Corporation",
"version": {
"Major": 2,
"Minor": 183,
"Minor": 185,
"Patch": 0
},
"releaseNotes": "Configuration of the SonarQube analysis was moved to the [SonarQube](https://marketplace.visualstudio.com/items?itemName=SonarSource.sonarqube) or [SonarCloud](https://marketplace.visualstudio.com/items?itemName=SonarSource.sonarcloud) extensions, in task `Prepare Analysis Configuration`",
Expand Down
2 changes: 1 addition & 1 deletion Tasks/MavenV2/task.loc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"author": "Microsoft Corporation",
"version": {
"Major": 2,
"Minor": 183,
"Minor": 185,
"Patch": 0
},
"releaseNotes": "ms-resource:loc.releaseNotes",
Expand Down
13 changes: 10 additions & 3 deletions Tasks/MavenV3/maventask.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,6 +297,11 @@ async function execBuild() {
});

// Do not force an exit as publishing results is async and it won't have finished
})
.fail(function (err) {
// Set task failure if get exception at step 5
console.error(err.message);
tl.setResult(tl.TaskResult.Failed, "Build failed.");
});
}

Expand Down Expand Up @@ -347,9 +352,11 @@ function publishJUnitTestResults(testResultsFiles: string) {
tl.debug('Pattern found in testResultsFiles parameter');
var buildFolder = tl.getVariable('System.DefaultWorkingDirectory');
tl.debug(`buildFolder=${buildFolder}`);
matchingJUnitResultFiles = tl.findMatch(buildFolder, testResultsFiles, null, {
matchBase: true
});
matchingJUnitResultFiles = tl.findMatch(buildFolder, testResultsFiles, {
followSymbolicLinks: true,
allowBrokenSymbolicLinks: true,
followSpecifiedSymbolicLink: true,
}, { matchBase: true });
}
else {
tl.debug('No pattern found in testResultsFiles parameter');
Expand Down
2 changes: 1 addition & 1 deletion Tasks/MavenV3/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"author": "Microsoft Corporation",
"version": {
"Major": 3,
"Minor": 183,
"Minor": 185,
"Patch": 0
},
"releaseNotes": "Configuration of the SonarQube analysis was moved to the [SonarQube](https://marketplace.visualstudio.com/items?itemName=SonarSource.sonarqube) or [SonarCloud](https://marketplace.visualstudio.com/items?itemName=SonarSource.sonarcloud) extensions, in task `Prepare Analysis Configuration`",
Expand Down
2 changes: 1 addition & 1 deletion Tasks/MavenV3/task.loc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"author": "Microsoft Corporation",
"version": {
"Major": 3,
"Minor": 183,
"Minor": 185,
"Patch": 0
},
"releaseNotes": "ms-resource:loc.releaseNotes",
Expand Down