-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MavenV2, MavenV3]: Fixed bug when task succeeds on tests failure #14658
Conversation
Manually tested these changes in this pipeline https://dev.azure.com/v-vryzhov/test/_build?definitionId=2 (#20210326.7, #20210326.6). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested these changes manually, everything is working as expected:
✔ Maven V2 test failures before
✔ Maven V3 test failures before
❌ Maven V2 test failures after
❌ Maven V3 test failures after
❌ Don't allow broken symlinks
✔ Allow broken symlinks
Take a look at the suggestion, but other than that LGTM!
Task name: MavenV2, MavenV3
Description: Maven task succeeded when tests failed. It was caused by incorrect exception handling on last stage of build.
Now the build will fail if tests don't finish successfully.
Added new optional input:
allowBrokenSymlinks
. If it is setfalse
the task will fail when it finds bad symbolic link during publishing tests. For backward-combability it is settrue
by default to ignore incorrect symbolic links when task tries to publish tests.Documentation changes required: Yes
Added unit tests: No
Attached related issue: #14514
Checklist:
✔️ Maven V3 succeeds when tests are passed and there is a bad symlink when task tries to publish tests (
allowBrokenSymlinks = true
)❌ Maven V3 fails when tests are passed (
allowBrokenSymlinks = false
). There is a bad symlink when task tries to publish tests❌ Maven V3 fails when tests are failed
✔️ Maven V2 succeeds when tests are passed and there is a bad symlink when task tries to publish tests (
allowBrokenSymlinks = true
)❌ Maven V2 fails when tests are passed (
allowBrokenSymlinks = false
). There is a bad symlink when task tries to publish tests)❌ Maven V2 fails when tests are failed
✔️ On canary app