Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating stable helm chart location #14124

Merged
merged 2 commits into from
Dec 23, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Tasks/HelmInstallerV0/src/helmtoolinstaller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ async function verifyHelm() {
var helmTool = tl.tool(helmToolPath);
helmTool.arg("init");
helmTool.arg("--client-only");
helmTool.arg("--stable-repo-url");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would work only for the latest versions right?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, looks to be specific to version specific problem.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, since the specified the url is valid, it doesn't matter what helm version is calling that url. It works with older versions also, I have verified it.

helmTool.arg("https://charts.helm.sh/stable");
return helmTool.exec()
}
}
Expand Down
2 changes: 1 addition & 1 deletion Tasks/HelmInstallerV0/task.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"author": "Microsoft Corporation",
"version": {
"Major": 0,
"Minor": 177,
"Minor": 180,
"Patch": 0
},
"demands": [],
Expand Down
2 changes: 1 addition & 1 deletion Tasks/HelmInstallerV0/task.loc.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
"author": "Microsoft Corporation",
"version": {
"Major": 0,
"Minor": 177,
"Minor": 180,
"Patch": 0
},
"demands": [],
Expand Down
2 changes: 2 additions & 0 deletions Tasks/HelmInstallerV1/src/helmtoolinstaller.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,8 @@ async function verifyHelm() {
var helmTool = tl.tool(helmToolPath);
helmTool.arg("init");
helmTool.arg("--client-only");
helmTool.arg("--stable-repo-url");
helmTool.arg("https://charts.helm.sh/stable");
return helmTool.exec()
}
}
Expand Down
4 changes: 2 additions & 2 deletions Tasks/HelmInstallerV1/task.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
"author": "Microsoft Corporation",
"version": {
"Major": 1,
"Minor": 175,
"Patch": 1
"Minor": 180,
"Patch": 0
},
"preview": true,
"demands": [],
Expand Down
4 changes: 2 additions & 2 deletions Tasks/HelmInstallerV1/task.loc.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
"author": "Microsoft Corporation",
"version": {
"Major": 1,
"Minor": 175,
"Patch": 1
"Minor": 180,
"Patch": 0
},
"preview": true,
"demands": [],
Expand Down