Updating stable helm chart location #14124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -41,6 +41,8 @@ async function verifyHelm() { | |||
| var helmTool = tl.tool(helmToolPath); | |||
| helmTool.arg("init"); | |||
| helmTool.arg("--client-only"); | |||
| helmTool.arg("--stable-repo-url"); | |||
There was a problem hiding this comment.
This would work only for the latest versions right?
There was a problem hiding this comment.
Yes, looks to be specific to version specific problem.
There was a problem hiding this comment.
No, since the specified the url is valid, it doesn't matter what helm version is calling that url. It works with older versions also, I have verified it.
This was referenced Dec 22, 2020
ajinkya599
approved these changes
Dec 23, 2020
amit-avit
pushed a commit
to amit-avit/azure-pipelines-tasks
that referenced
this pull request
Jan 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: HelmInstallerV0, HelmInstallerV1
Description: Updating the stable helm chart location to fix breaking helm init command
Documentation changes required: (Y/N) N
Added unit tests: (Y/N) N
Attached related issue: (Y/N) N
Checklist: