Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node execution upgrade to Node10 #14014

Merged
merged 13 commits into from
Jan 7, 2021
Merged

Node execution upgrade to Node10 #14014

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
00f5885
AzureKeyVaultV1
thesattiraju Dec 2, 2020
3bb48da
ContainerBuildV0
thesattiraju Dec 2, 2020
4459a18
DuffleInstallerV0
thesattiraju Dec 2, 2020
12a022b
Execution: Node10 AzureKeyVault and ContainerBuild
thesattiraju Dec 2, 2020
48c0eae
GitHubReleaseV0
thesattiraju Dec 2, 2020
6710dfb
GitHubReleaseV1
thesattiraju Dec 2, 2020
5c6cb6f
KubernetesManifestV0
thesattiraju Dec 2, 2020
0cc5b2d
Merge branch 'master' of github.com:microsoft/azure-pipelines-tasks i…
thesattiraju Jan 6, 2021
51cba90
Updating common modules to preview
thesattiraju Jan 6, 2021
592c4a6
DockerComposeV0
thesattiraju Jan 6, 2021
6225ca4
DockerInstallerV0
thesattiraju Jan 6, 2021
a0f3517
MochaDone to Mocha.Done
thesattiraju Jan 7, 2021
0fb2e4c
Merge branch 'master' into users/desattir/node-upgrade
thesattiraju Jan 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 22 additions & 6 deletions Tasks/AzureKeyVaultV1/npm-shrinkwrap.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion Tasks/AzureKeyVaultV1/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,16 @@
"name": "AzureKeyVault",
"main": "main.js",
"dependencies": {
"@types/node": "^6.0.101",
"@types/node": "^10.17.0",
"@types/mocha": "^5.2.7",
"@types/uuid": "^8.3.0",
"@types/q": "^1.5.0",
"azure-pipelines-tasks-azure-arm-rest-v2": "1.0.4",
"azure-pipelines-task-lib": "2.8.0",
"moment": "2.21.0",
"vso-node-api": "6.0.1-preview"
},
"devDependencies": {
"typescript": "4.0.2"
}
}
8 changes: 4 additions & 4 deletions Tasks/AzureKeyVaultV1/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
"author": "Microsoft Corporation",
"version": {
"Major": 1,
"Minor": 175,
"Patch": 2
"Minor": 180,
"Patch": 0
},
"demands": [],
"minimumAgentVersion": "2.0.0",
Expand Down Expand Up @@ -74,12 +74,12 @@
],
"instanceNameFormat": "Azure Key Vault: $(KeyVaultName)",
"prejobexecution": {
"Node": {
"Node10": {
"target": "runprejob.js"
}
},
"execution": {
"Node": {
"Node10": {
"target": "run.js"
}
},
Expand Down
8 changes: 4 additions & 4 deletions Tasks/AzureKeyVaultV1/task.loc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,8 @@
"author": "Microsoft Corporation",
"version": {
"Major": 1,
"Minor": 175,
"Patch": 2
"Minor": 180,
"Patch": 0
},
"demands": [],
"minimumAgentVersion": "2.0.0",
Expand Down Expand Up @@ -74,12 +74,12 @@
],
"instanceNameFormat": "ms-resource:loc.instanceNameFormat",
"prejobexecution": {
"Node": {
"Node10": {
"target": "runprejob.js"
}
},
"execution": {
"Node": {
"Node10": {
"target": "run.js"
}
},
Expand Down
37 changes: 25 additions & 12 deletions Tasks/ContainerBuildV0/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions Tasks/ContainerBuildV0/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,15 @@
{
"dependencies": {
"@types/node": "^10.17.0",
"@types/mocha": "^5.2.7",
"@types/uuid": "^8.3.0",
"azure-pipelines-tasks-azure-arm-rest-v2": "1.0.3",
"azure-pipelines-task-lib": "2.8.0",
"azure-pipelines-tasks-docker-common-v2": "1.0.0",
"azure-pipelines-tool-lib": "0.11.0",
"consistent-hashing": "0.3.0"
},
"devDependencies": {
"typescript": "4.0.2"
}
}
6 changes: 3 additions & 3 deletions Tasks/ContainerBuildV0/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
"author": "Microsoft Corporation",
"version": {
"Major": 0,
"Minor": 175,
"Patch": 1
"Minor": 180,
"Patch": 0
},
"demands": [],
"satisfies": [
Expand Down Expand Up @@ -65,7 +65,7 @@
],
"instanceNameFormat": "Container Build Task",
"execution": {
"Node": {
"Node10": {
"target": "src//buildcontainer.js"
}
},
Expand Down
6 changes: 3 additions & 3 deletions Tasks/ContainerBuildV0/task.loc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
"author": "Microsoft Corporation",
"version": {
"Major": 0,
"Minor": 175,
"Patch": 1
"Minor": 180,
"Patch": 0
},
"demands": [],
"satisfies": [
Expand Down Expand Up @@ -65,7 +65,7 @@
],
"instanceNameFormat": "ms-resource:loc.instanceNameFormat",
"execution": {
"Node": {
"Node10": {
"target": "src//buildcontainer.js"
}
},
Expand Down
60 changes: 28 additions & 32 deletions Tasks/DuffleInstallerV0/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 6 additions & 1 deletion Tasks/DuffleInstallerV0/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,14 @@
{
"dependencies": {
"@types/node": "^6.0.101",
"@types/mocha": "^5.2.7",
"@types/node": "^10.17.0",
"@types/q": "^1.5.0",
"@types/uuid": "^8.3.0",
"azure-pipelines-task-lib": "2.8.0",
"azure-pipelines-tool-lib": "0.11.0",
"utility-common-v2": "file:../../_build/Tasks/Common/utility-common-v2-2.0.0.tgz"
},
"devDependencies": {
"typescript": "4.0.2"
}
}
2 changes: 1 addition & 1 deletion Tasks/DuffleInstallerV0/src/duffleinstaller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ async function downloadDuffle(version: string): Promise<string> {
}

const dufflePath = path.join(cachedToolPath, DuffleToolName + getExecutableExtension());
fs.chmod(dufflePath, '777');
fs.chmodSync(dufflePath, '777');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this required as part of Node 10 upgrade?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup. In Node6 chmod was synchronous by default

return dufflePath;
}

Expand Down
Loading