Node execution upgrade to Node10 #14014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesattiraju
requested review from
ammohant,
mdmdakbar and
prebansa
as code owners
shigupt202
approved these changes
Dec 7, 2020
|
I think |
shigupt202
reviewed
Jan 7, 2021
| @@ -39,7 +39,7 @@ async function downloadDuffle(version: string): Promise<string> { | |||
| } | |||
|
|
|||
| const dufflePath = path.join(cachedToolPath, DuffleToolName + getExecutableExtension()); | |||
| fs.chmod(dufflePath, '777'); | |||
| fs.chmodSync(dufflePath, '777'); | |||
There was a problem hiding this comment.
Is this required as part of Node 10 upgrade?
There was a problem hiding this comment.
Yup. In Node6 chmod was synchronous by default
thesattiraju
added a commit
that referenced
this pull request
Jan 7, 2021
* AzureKeyVaultV1 * ContainerBuildV0 * DuffleInstallerV0 * Execution: Node10 AzureKeyVault and ContainerBuild * GitHubReleaseV0 * GitHubReleaseV1 * KubernetesManifestV0 * Updating common modules to preview * DockerComposeV0 * DockerInstallerV0 * MochaDone to Mocha.Done
thesattiraju
added a commit
that referenced
this pull request
Jan 7, 2021
* AzureKeyVaultV1 * ContainerBuildV0 * DuffleInstallerV0 * Execution: Node10 AzureKeyVault and ContainerBuild * GitHubReleaseV0 * GitHubReleaseV1 * KubernetesManifestV0 * Updating common modules to preview * DockerComposeV0 * DockerInstallerV0 * MochaDone to Mocha.Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task name: AzureKeyVaultV1, ContainerBuildV0, DockerComposeV0, DockerInstallerV0, DuffleInstallerV0, GitHubReleaseV0, GitHubReleaseV1, KubernetesManifestV0,
Description: Upgrading the tasks execution to
Node10Documentation changes required: N
Checklist: