Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating AzureResourceManagerTemplateDeploymentV3 task to consume arm… #13870

Merged
merged 4 commits into from
Nov 12, 2020
Merged

Updating AzureResourceManagerTemplateDeploymentV3 task to consume arm… #13870

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
63b1033
Updating AzureResourceManagerTemplateDeploymentV3 task to consume arm…
anuragc617 Nov 10, 2020
323a037
Merge branch 'master' into users/anchauh/updateARGV3
anuragc617 Nov 10, 2020
ed0ad70
fixing resource path warnings
anuragc617 Nov 10, 2020
9a8747b
Merge branch 'master' into users/anchauh/updateARGV3
anuragc617 Nov 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Tasks/AzureResourceManagerTemplateDeploymentV3/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ function run(): Promise<void> {
var taskManifestPath = path.join(__dirname, "task.json");
tl.debug("Setting resource path to " + taskManifestPath);
tl.setResourcePath(taskManifestPath);
tl.setResourcePath(path.join( __dirname, 'node_modules/azure-pipelines-tasks-azure-arm-rest-v2/module.json'));
tl.setResourcePath(path.join( __dirname, 'node_modules/azure-pipelines-tasks-azure-arm-rest-v2/module.json'), true);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need this. right? as each file in module will do this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, each file in module doing this. But I think there is no harm in keeping it as it will only try to add if not already added.


run().then((result) =>
tl.setResult(tl.TaskResult.Succeeded, "")
Expand Down
161 changes: 151 additions & 10 deletions Tasks/AzureResourceManagerTemplateDeploymentV3/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Tasks/AzureResourceManagerTemplateDeploymentV3/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@
"name": "AzureResourceManagerTemplateDeployment",
"main": "main.js",
"dependencies": {
"azure-pipelines-tasks-azure-arm-rest-v2": "1.0.5",
"azure-pipelines-task-lib": "2.8.0",
"azure-pipelines-tasks-azure-arm-rest-v2": "1.178.1",
"azure-pipelines-task-lib": "2.11.2",
"moment": "2.21.0",
"typed-rest-client": "1.7.3"
}
Expand Down
2 changes: 1 addition & 1 deletion Tasks/AzureResourceManagerTemplateDeploymentV3/task.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"author": "Microsoft Corporation",
"version": {
"Major": 3,
"Minor": 176,
"Minor": 179,
"Patch": 0
},
"demands": [],
Expand Down
2 changes: 1 addition & 1 deletion Tasks/AzureResourceManagerTemplateDeploymentV3/task.loc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"author": "Microsoft Corporation",
"version": {
"Major": 3,
"Minor": 176,
"Minor": 179,
"Patch": 0
},
"demands": [],
Expand Down