Updating AzureResourceManagerTemplateDeploymentV3 task to consume arm… #13870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -61,7 +61,7 @@ function run(): Promise<void> { | |||
| var taskManifestPath = path.join(__dirname, "task.json"); | |||
| tl.debug("Setting resource path to " + taskManifestPath); | |||
| tl.setResourcePath(taskManifestPath); | |||
| tl.setResourcePath(path.join( __dirname, 'node_modules/azure-pipelines-tasks-azure-arm-rest-v2/module.json')); | |||
| tl.setResourcePath(path.join( __dirname, 'node_modules/azure-pipelines-tasks-azure-arm-rest-v2/module.json'), true); | |||
There was a problem hiding this comment.
we don't need this. right? as each file in module will do this.
There was a problem hiding this comment.
Yes, each file in module doing this. But I think there is no harm in keeping it as it will only try to add if not already added.
bishal-pdMSFT
approved these changes
Nov 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating AzureResourceManagerTemplateDeploymentV3 task to consume arm-rest-v2 1.178.1
Task name:
Description: Consuming graph client endpoint fix
Documentation changes required: (N)
Added unit tests: (N)
Attached related issue: (Y) #13797
Checklist: