-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CmdLine does not forwarding signals #13573
Conversation
1682336
to
94d03d0
Compare
Please check if we need to apply changes for Powershell handler too |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
This problem is actual only for unix systems as Windows doesn't support POSIX signals and we can't send specific signals from Bash and CmdLine tasks on windows, so the the changes for powershell handler is unnecessary.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please take a look at the comments? Other changes LGTM.
@damccorm Could you please take a look this pr? |
5f9e0c4
to
bcaf338
Compare
bcaf338
to
a86d2f4
Compare
Task name:
BashV3, CmdLineV2
Description:
Was added sending signals to the task child processes. (Need to trap SIGTERM signal in bash script)
Documentation changes required: (Y/N)
No
Added unit tests: (Y/N)
No
Attached related issue: (Y/N)
#11468
Checklist: