Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CmdLine does not forwarding signals #13573

Merged
merged 6 commits into from
Sep 24, 2020

Conversation

EzzhevNikita
Copy link
Contributor

@EzzhevNikita EzzhevNikita commented Sep 18, 2020

Task name:
BashV3, CmdLineV2

Description:
Was added sending signals to the task child processes. (Need to trap SIGTERM signal in bash script)

Documentation changes required: (Y/N)
No
Added unit tests: (Y/N)
No
Attached related issue: (Y/N)
#11468
Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@EzzhevNikita EzzhevNikita added bug Area: ABTT Akvelon Build Tasks Team area of work Task: Bash labels Sep 18, 2020
@EzzhevNikita EzzhevNikita self-assigned this Sep 18, 2020
@EzzhevNikita EzzhevNikita force-pushed the users/EzzhevNikita/fix-cmdln-task branch from 1682336 to 94d03d0 Compare September 18, 2020 15:15
@anatolybolshakov anatolybolshakov requested a review from a team September 18, 2020 15:31
@anatolybolshakov anatolybolshakov requested a review from a team September 21, 2020 07:15
@anatolybolshakov
Copy link
Contributor

Please check if we need to apply changes for Powershell handler too

Copy link
Contributor

@anatolybolshakov anatolybolshakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@EzzhevNikita
Copy link
Contributor Author

EzzhevNikita commented Sep 21, 2020

This problem is actual only for unix systems as Windows doesn't support POSIX signals and we can't send specific signals from Bash and CmdLine tasks on windows, so the the changes for powershell handler is unnecessary.

Please check if we need to apply changes for Powershell handler too

Copy link
Contributor

@alexander-smolyakov alexander-smolyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please take a look at the comments? Other changes LGTM.

Tasks/BashV3/bash.ts Show resolved Hide resolved
Tasks/BashV3/bash.ts Show resolved Hide resolved
Tasks/CmdLineV2/cmdline.ts Show resolved Hide resolved
Tasks/CmdLineV2/cmdline.ts Show resolved Hide resolved
@EzzhevNikita
Copy link
Contributor Author

@damccorm Could you please take a look this pr?

@EzzhevNikita EzzhevNikita linked an issue Sep 22, 2020 that may be closed by this pull request
Tasks/BashV3/bash.ts Show resolved Hide resolved
Tasks/CmdLineV2/cmdline.ts Show resolved Hide resolved
@EzzhevNikita EzzhevNikita force-pushed the users/EzzhevNikita/fix-cmdln-task branch from 5f9e0c4 to bcaf338 Compare September 24, 2020 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: ABTT Akvelon Build Tasks Team area of work bug Task: Bash
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CmdLine does not forwarding signals
4 participants