CMDLineV2 task not failing when executed program terminates due to error

[jackdeansmith]

Question, Bug, or Feature?
Type: Bug

Enter Task Name: CMDLineV2

Environment

• Server: Azure Pipelines
• Account Name: SkyDrive
• Team Project Name: CrossPlatform
• Build definition name: iOS Run xPlat Unit Tests
• Agent: Hosted Mac Internal Mojave

Issue Description

This pipeline is used as a PR gate in our repo to ensure that checked in code passes our unit tests. It consists of a few steps that create a test binary, then this "Run unit tests" step that executes the test binary:

We recently noticed that this task succeeds in cases where the test executable terminates due to an error. In this case, a segfault:

Because of this, code that does not pass our unit tests was allowed into our repo.

Minimal Repro

I created a minimal repro by creating a pipeline with three steps:

1. Create an executable which exits with an error by segfaulting
   

2. Run the executable via the CmdLineV2 Task
   

3. Run the executable via the BashV3 Task
   

When I run this pipeline, task 2 succeeds while task 3 fails. Note that the printed script contents are not the same, for the CmdLineV2 task, the script is prepended with exec.

Based on this and the final few debug message, I believe this is related to this PR: #13573

Task logs

Production unit test pipeline logs:
logs_8835843.zip

Logs for minimal repro:
logs_8852883.zip

[EzzhevNikita]

@jackdeansmith The fix for has been deployed. Could you please check if it works for you now?

[jackdeansmith]

@EzzhevNikita I just tried again and everything is working as expected. Thanks for getting to the bottom of this!