Added environment link and describe dump for supportablity #12038
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,18 +7,34 @@ import * as KubernetesConstants from './kubernetesconstants'; | |
| import { Kubectl, Resource } from './kubectl-object-model'; | ||
|
|
||
| export async function checkManifestStability(kubectl: Kubectl, resources: Resource[], timeoutInSeconds?: string): Promise<void> { | ||
| const environmentUrl = getEnvironmentUrl(); | ||
| if (environmentUrl) | ||
| tl.debug('For more information, go to ' + environmentUrl); | ||
|
|
||
| let rolloutStatusHasErrors = false; | ||
| const numberOfResources = resources.length; | ||
| for (let i = 0; i < numberOfResources; i++) { | ||
| const resource = resources[i]; | ||
| if (KubernetesConstants.workloadTypesWithRolloutStatus.indexOf(resource.type.toLowerCase()) >= 0) { | ||
| try { | ||
| let result = kubectl.checkRolloutStatus(resource.type, resource.name, timeoutInSeconds); | ||
| utils.checkForErrors([result]); | ||
| } catch (ex) { | ||
| tl.error(ex); | ||
| kubectl.describe(resource.type, resource.name); | ||
| if (environmentUrl) | ||
| console.log(tl.loc('EnvironmentLink', environmentUrl)); | ||
| rolloutStatusHasErrors = true; | ||
| } | ||
| } | ||
| if (utils.isEqual(resource.type, KubernetesConstants.KubernetesWorkload.pod, true)) { | ||
| try { | ||
| await checkPodStatus(kubectl, resource.name); | ||
| } catch (ex) { | ||
| tl.warning(tl.loc('CouldNotDeterminePodStatus', JSON.stringify(ex))); | ||
| kubectl.describe(resource.type, resource.name); | ||
| if (environmentUrl) | ||
| console.log(tl.loc('EnvironmentLink', environmentUrl)); | ||
| } | ||
| } | ||
| if (utils.isEqual(resource.type, KubernetesConstants.DiscoveryAndLoadBalancerResource.service, true)) { | ||
|
|
@@ -35,11 +51,16 @@ export async function checkManifestStability(kubectl: Kubectl, resources: Resour | |
| } | ||
| } catch (ex) { | ||
| tl.warning(tl.loc('CouldNotDetermineServiceStatus', resource.name, JSON.stringify(ex))); | ||
| kubectl.describe(resource.type, resource.name); | ||
| if (environmentUrl) | ||
| console.log(tl.loc('EnvironmentLink', environmentUrl)); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| if (rolloutStatusHasErrors) { | ||
| throw new Error(tl.loc('RolloutStatusTimedout')); | ||
| } | ||
| } | ||
|
|
||
| export async function checkPodStatus(kubectl: Kubectl, podName: string): Promise<void> { | ||
|
|
@@ -55,20 +76,31 @@ export async function checkPodStatus(kubectl: Kubectl, podName: string): Promise | |
| } | ||
| } | ||
| podStatus = getPodStatus(kubectl, podName); | ||
| const environmentUrl = getEnvironmentUrl(); | ||
| switch (podStatus.phase) { | ||
| case 'Succeeded': | ||
| case 'Running': | ||
| if (isPodReady(podStatus)) { | ||
| console.log(`pod/${podName} is successfully rolled out`); | ||
| } else { | ||
| kubectl.describe(KubernetesConstants.KubernetesWorkload.pod, podName); | ||
| if (environmentUrl) | ||
| console.log(tl.loc('EnvironmentLink', environmentUrl)); | ||
| } | ||
| break; | ||
| case 'Pending': | ||
| if (!isPodReady(podStatus)) { | ||
| tl.warning(`pod/${podName} rollout status check timedout`); | ||
| kubectl.describe(KubernetesConstants.KubernetesWorkload.pod, podName); | ||
| if (environmentUrl) | ||
| console.log(tl.loc('EnvironmentLink', environmentUrl)); | ||
| } | ||
| break; | ||
| case 'Failed': | ||
| tl.error(`pod/${podName} rollout failed`); | ||
| kubectl.describe(KubernetesConstants.KubernetesWorkload.pod, podName); | ||
| if (environmentUrl) | ||
| console.log(tl.loc('EnvironmentLink', environmentUrl)); | ||
| break; | ||
| default: | ||
| tl.warning(`pod/${podName} rollout status: ${podStatus.phase}`); | ||
|
|
@@ -124,4 +156,16 @@ function isLoadBalancerIPAssigned(status: any) { | |
| return true; | ||
| } | ||
| return false; | ||
| } | ||
|
|
||
| function getEnvironmentUrl(): string { | ||
| const environmentId = tl.getVariable('Environment.Id'); | ||
| let requestUrl = null; | ||
| if (environmentId) { | ||
| requestUrl = tl.getVariable('System.TeamFoundationCollectionUri') + tl.getVariable('System.TeamProject') + '/_environments/' + tl.getVariable('Environment.Id'); | ||
| const resourceId = tl.getVariable('Environment.ResourceId'); | ||
| requestUrl = resourceId ? requestUrl + '/providers/kubernetes/' + resourceId : requestUrl; | ||
|
Comment on lines
+153
to
+155
There was a problem hiding this comment. Can this be done at server side? Where you dump a variable called @vithati thoughts? There was a problem hiding this comment. We can do that enhancement later. |
||
| } | ||
|
|
||
| return requestUrl; | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move this to private function and use other places.