Added environment link and describe dump for supportablity #12038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ttps://github.com/microsoft/azure-pipelines-tasks into users/shigupt/supportabilityForKubernetesManifest
thesattiraju
approved these changes
Jan 7, 2020
Comment on lines
+165
to
+167
| requestUrl = tl.getVariable('System.TeamFoundationCollectionUri') + tl.getVariable('System.TeamProject') + '/_environments/' + tl.getVariable('Environment.Id'); | ||
| const resourceId = tl.getVariable('Environment.ResourceId'); | ||
| requestUrl = resourceId ? requestUrl + '/providers/kubernetes/' + resourceId : requestUrl; |
There was a problem hiding this comment.
Can this be done at server side? Where you dump a variable called Environment.ResourceUrl or something like that?
@vithati thoughts?
There was a problem hiding this comment.
We can do that enhancement later.
| } | ||
| } | ||
| } | ||
|
|
||
| utils.checkForErrors(rolloutStatusResults); | ||
| if (rolloutStatusHasErrors) { | ||
| throw new Error('Rollout status check failed.'); |
There was a problem hiding this comment.
this message should come from task.json
| } else { | ||
| kubectl.describe(KubernetesConstants.KubernetesWorkload.pod, podName); | ||
| if (environmentUrl) | ||
| console.log('For more information go to ' + environmentUrl); |
There was a problem hiding this comment.
This should come from task.json too
| } | ||
| break; | ||
| case 'Pending': | ||
| if (!isPodReady(podStatus)) { | ||
| tl.warning(`pod/${podName} rollout status check timedout`); | ||
| kubectl.describe(KubernetesConstants.KubernetesWorkload.pod, podName); | ||
| if (environmentUrl) | ||
| console.log('For more information go to ' + environmentUrl); |
There was a problem hiding this comment.
Every message shown to user should come from task.json.
If it's a debug statement you can skip it. This would end up raising localization errors later on otherwise.
There was a problem hiding this comment.
Okay. I'll change that
| } | ||
| break; | ||
| case 'Failed': | ||
| tl.error(`pod/${podName} rollout failed`); | ||
| kubectl.describe(KubernetesConstants.KubernetesWorkload.pod, podName); | ||
| if (environmentUrl) | ||
| console.log('For more information go to ' + environmentUrl); |
…ttps://github.com/microsoft/azure-pipelines-tasks into users/shigupt/supportabilityForKubernetesManifest
vithati
suggested changes
Jan 7, 2020
| utils.checkForErrors([result]); | ||
| } catch (ex) { | ||
| tl.error(ex); | ||
| kubectl.describe(resource.type, resource.name); |
There was a problem hiding this comment.
Move this to private function and use other places.
Comment on lines
+165
to
+167
| requestUrl = tl.getVariable('System.TeamFoundationCollectionUri') + tl.getVariable('System.TeamProject') + '/_environments/' + tl.getVariable('Environment.Id'); | ||
| const resourceId = tl.getVariable('Environment.ResourceId'); | ||
| requestUrl = resourceId ? requestUrl + '/providers/kubernetes/' + resourceId : requestUrl; |
There was a problem hiding this comment.
We can do that enhancement later.
vithati
approved these changes
Jan 7, 2020
…ttps://github.com/microsoft/azure-pipelines-tasks into users/shigupt/supportabilityForKubernetesManifest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added environment link and describe dump for supportablity