Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DownloadPipelineArtifactV2] Add minimumBuildStatus property #11664

Merged
merged 12 commits into from
Nov 22, 2019
Merged

[DownloadPipelineArtifactV2] Add minimumBuildStatus property #11664

merged 12 commits into from
Nov 22, 2019

Conversation

Thilas
Copy link
Contributor

@Thilas Thilas commented Oct 30, 2019

@jahsu-MSFT, @johnterickson, as discussed in #11556, here are my changes that add a minimumBuildStatus property to the DownloadPipelineArtifactV2 task.

@Thilas
Copy link
Contributor Author

Thilas commented Oct 30, 2019

Related changes: microsoft/azure-pipelines-agent#2560

@jahsu-MSFT
Copy link
Contributor

jahsu-MSFT commented Oct 30, 2019 •
edited
Loading

Need to update the task version as well. This should probably be a minor update.

@jahsu-MSFT jahsu-MSFT self-requested a review October 30, 2019 23:40
@Thilas
Copy link
Contributor Author

Thilas commented Oct 31, 2019

@jahsu-MSFT, do you mean in the task.json file? I thought this part was automatic.

@jahsu-MSFT
Copy link
Contributor

jahsu-MSFT commented Oct 31, 2019 •
edited
Loading

Yes in the task.json file. This needs to be updated manually.
image

@Thilas
Copy link
Contributor Author

Thilas commented Oct 31, 2019

@jahsu-MSFT, done.

@Thilas Thilas mentioned this pull request Nov 2, 2019
Closed
@jahsu-MSFT
Copy link
Contributor

jahsu-MSFT commented Nov 4, 2019 •
edited
Loading

Since the DPA V2 version got updated in master. (It's 2.1.0 now) You will need to update to 2.2.0 so the task will get updated after the code is merged. Thanks.

cc @johnterickson

@Thilas
Copy link
Contributor Author

Thilas commented Nov 4, 2019

@jahsu-MSFT, it is done.

@johnterickson
Copy link
Contributor

@Thilas thanks for the contribution! 🙌

@jahsu-MSFT
Copy link
Contributor

@Thilas the new agent version should be released next week and the deployment process should be able to complete by next Friday. We will fix the conflicts, update the min-agent version and then merge the task PR by then. :) Thanks again for contributing.

@Thilas
Copy link
Contributor Author

Thilas commented Nov 15, 2019

@jahsu-MSFT, that's great news! Let me know if you want me to do any of these actions, I really don't mind. And thank you for your support on this PR.

@jahsu-MSFT
Copy link
Contributor

jahsu-MSFT commented Nov 22, 2019 •
edited
Loading

@Thilas Sure. By we I mean you and us. Can you please sync with master again, bump the task version one more time if needed, and update the min-agent version to 2.161.0?
Thanks,

@Thilas
Copy link
Contributor Author

Thilas commented Nov 22, 2019

@jahsu-MSFT, it's done. FYI I didn't need to bump the version since it was 2.1.2 (formerly 2.1.0) and we already set it to 2.2.0. I'll let you do the final magic 😉

@jahsu-MSFT
Copy link
Contributor

Looks good to me. Thanks again for contributing @Thilas
I'm going to merge the PR. Since we won't be deploying on the Thanksgiving week, the code should be deployed on the first week of December. :)

@jahsu-MSFT jahsu-MSFT merged commit 25fd64f into microsoft:master Nov 22, 2019
@Thilas Thilas deleted the download-artifacts-from-failed-builds branch November 22, 2019 20:02
@Thilas
Copy link
Contributor Author

Thilas commented Nov 22, 2019

Thanks again for your support @jahsu-MSFT.

@StefanSchoof
Copy link
Contributor

StefanSchoof commented Dec 18, 2019 •
edited
Loading

The roll out of this PR has broken our Pipeline. The Agent Version in the hosted image in west Europe is 2.160.1 and ad this set the required Version to 2.161.

@jahsu-MSFT
Copy link
Contributor

jahsu-MSFT commented Dec 18, 2019 •
edited
Loading

@StefanSchoof Thanks for reporting. Yes, there was a glitch of the timing when agent was released and when this task was released. Sorry for the inconvenience. I believe this issue has been resolved now. Please let us know if you're still seeing any issues.

Also what type of agent pool you are using?

@StefanSchoof
Copy link
Contributor

@jahsu-MSFT Thanks, now the Agent is on 2.163.1 and everything is working.

leantk pushed a commit that referenced this pull request Dec 23, 2019
@Thilas @leantk
[DownloadPipelineArtifactV2] Add minimumBuildStatus property (#11664)
d987548 
* Add parameter to support partially succeeded and failed builds

Fixes #11556

* Minor version update

* Replace minimumBuildStatus parameter by allowPartiallySucceededBuilds and allowFailedBuilds

* Increment minor version

* Update min agent version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jahsu-MSFT jahsu-MSFT jahsu-MSFT approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Thilas @jahsu-MSFT @johnterickson @StefanSchoof