[PipelineArtifactPluginV2] Add support of minimumBuildStatus property #2560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and allowFailedBuilds
|
Thanks @Thilas . The agent change looks good to me. Please re-sync with master and fix the conflicts. cc @johnterickson |
jahsu-MSFT
reviewed
Nov 4, 2019
| @@ -177,15 +190,15 @@ public class DownloadPipelineArtifactTaskV2_0_0 : PipelineArtifactTaskPluginBase | |||
| { | |||
| if (pipelineVersionToDownload == pipelineVersionToDownloadLatest) | |||
| { | |||
| pipelineId = await this.GetPipelineIdAsync(context, pipelineDefinition, pipelineVersionToDownload, projectName, tagsInput); | |||
There was a problem hiding this comment.
We can pass the resultFilter to the function and set default to Succeed so that we don't need to always pass two bool variables here.
# Conflicts: # src/Agent.Plugins/PipelineArtifact/PipelineArtifactPluginV2.cs
|
All done, I let you finalize the review. Thanks. |
jahsu-MSFT
approved these changes
Nov 4, 2019
|
Looks good to me. I'm approving the code changes in the agent first since we need to wait until the agent is released and then release the task. @jtpetty Can you please take a look and merge the PR. Thanks, |
|
Thank you! |
jtpetty
pushed a commit
that referenced
this pull request
Dec 18, 2019
jtpetty
pushed a commit
that referenced
this pull request
Dec 18, 2019
* Cherry picking #2560 to m163 * bump version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@jahsu-MSFT, @johnterickson, as discussed in microsoft/azure-pipelines-tasks#11556, here are my changes that add a
minimumBuildStatusproperty to the PipelineArtifactPluginV2 task plugin.