-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added SMI canary deployment strategy to KubernetesManifest task #11218
Merged
Merged
Changes from 5 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
352bae3
Addressed the comments.
vithati 54bac58
Addressed comments.
vithati e6ffc58
merge
vithati 30c7fad
Fixed L0 tests.
vithati c9c7d42
Addressed comments.
vithati 43d8bbd
Fixed typo.
vithati 1b7172d
.
vithati 09ca9a4
Merge branch 'master' of https://github.com/microsoft/azure-pipelines…
vithati File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,26 @@ | ||
'use strict'; | ||
import * as tl from 'azure-pipelines-task-lib/task'; | ||
import * as canaryDeploymentHelper from '../utils/CanaryDeploymentHelper'; | ||
import * as SMICanaryDeploymentHelper from '../utils/SMICanaryDeploymentHelper'; | ||
import { Kubectl } from 'kubernetes-common-v2/kubectl-object-model'; | ||
import * as utils from '../utils/utilities'; | ||
import * as TaskInputParameters from '../models/TaskInputParameters'; | ||
|
||
export async function reject(ignoreSslErrors?: boolean) { | ||
const kubectl = new Kubectl(await utils.getKubectl(), TaskInputParameters.namespace, ignoreSslErrors); | ||
|
||
if (canaryDeploymentHelper.isCanaryDeploymentStrategy()) { | ||
tl.debug('Deployment strategy selected is Canary. Deleting baseline and canary workloads.'); | ||
canaryDeploymentHelper.deleteCanaryDeployment(kubectl, TaskInputParameters.manifests); | ||
} else { | ||
if (!canaryDeploymentHelper.isCanaryDeploymentStrategy()) { | ||
tl.debug('Strategy is not canary deployment. Invalid request.'); | ||
throw (tl.loc('InvalidRejectActionDeploymentStrategy')); | ||
} | ||
|
||
let includeServices = false; | ||
if (canaryDeploymentHelper.isSMICanaryStrategy()) { | ||
tl.debug('Reject deployment with SMI canary strategy'); | ||
includeServices = true; | ||
SMICanaryDeploymentHelper.redirectTrafficToStableDeployment(kubectl, TaskInputParameters.manifests); | ||
} | ||
|
||
tl.debug('Deployment strategy selected is Canary. Deleting baseline and canary workloads.'); | ||
canaryDeploymentHelper.deleteCanaryDeployment(kubectl, TaskInputParameters.manifests, includeServices); | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just want to confirm, Redirecting entire traffic to canary during promote, how are we making sure Canary pods can handle that much traffic?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In SMI, first you will redirect traffic to other deploymnt(canary) before updating stable. Generally customer will increase the canary pods before updating stable one.