Added SMI canary deployment strategy to KubernetesManifest task #11218
Conversation
Tasks/KubernetesManifestV0/Strings/resources.resjson/en-US/resources.resjson
Outdated
Show resolved
Hide resolved
|
Tests are failing. Could you check if the expected behavior for default ones are changing? |
|
Given that this logic works only if any service mesh is enabled on the cluster, shouldn't you add a check if it exists on the cluster? |
| @@ -11,7 +11,10 @@ | |||
| "loc.input.help.namespace": "Sets the namespace for the commands by using the –namespace flag. If the namespace is not provided, the commands will run in the default namespace.", | |||
| "loc.input.label.strategy": "Strategy", | |||
| "loc.input.help.strategy": "Deployment strategy to be used", | |||
| "loc.input.label.trafficSplitMethod": "Traffic split method", | |||
| "loc.input.help.trafficSplitMethod": "Deployment strategy to be used", | |||
There was a problem hiding this comment.
Label and help are looking like related. Can we add some more details in 'Help'.
There was a problem hiding this comment.
i will check with PM and will add.
Tasks/KubernetesManifestV0/Strings/resources.resjson/en-US/resources.resjson
Outdated
Show resolved
Hide resolved
vithati
force-pushed
the
users/vithati/k8sm
branch
from
dbb4f20 to
e6ffc58
Compare
| "apiVersion": "split.smi-spec.io/v1alpha1", | ||
| "kind": "TrafficSplit", | ||
| "metadata": { | ||
| "name": "%s" |
There was a problem hiding this comment.
You could directly use ` and replace it here instead of using formatter
| // In case of SMI traffic split strategy when deployment is promoted, first we will redirect traffic to | ||
| // Canary deployment, then update stable deployment and then redirect traffic to stable deployment | ||
| tl.debug('Redirecting traffic to canary deployment'); | ||
| SMICanaryDeploymentHelper.redirectTrafficToCanaryDeployment(kubectl, TaskInputParameters.manifests); |
There was a problem hiding this comment.
Just want to confirm, Redirecting entire traffic to canary during promote, how are we making sure Canary pods can handle that much traffic?
There was a problem hiding this comment.
In SMI, first you will redirect traffic to other deploymnt(canary) before updating stable. Generally customer will increase the canary pods before updating stable one.
vithati
force-pushed
the
users/vithati/k8sm
branch
from
9c0a66b to
09ca9a4
Compare
Added SMI canary deployment strategy to KubernetesManifest task