Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Porting to M154: Searching for csproj, fsproj that uses Microsoft.Net.Sdk.Web (#10704) #10775

Merged

Conversation

issacnitin
Copy link
Contributor

  • Searching for csproj, vbproj, fsproj using sdk Microsoft.Net.Sdk.Web

  • Updating package.json

  • Updating error message

  • Review comments

  • Review comments

  • Try-catch

  • Iteratively find and check for file encodings

  • Review comments

  • Supporting only utf encodings

  • L0

  • Adding semicolons

  • Removing vbproj

  • Comments

  • Updating error message

  • Updating error message

* Searching for csproj, vbproj, fsproj using sdk Microsoft.Net.Sdk.Web

* Updating package.json

* Updating error message

* Review comments

* Review comments

* Try-catch

* Iteratively find and check for file encodings

* Review comments

* Supporting only utf encodings

* L0

* Adding semicolons

* Removing vbproj

* Comments

* Updating error message

* Updating error message
* Updating L0

* Removing unnecessary imports

* Review comments
@issacnitin issacnitin merged commit 2d5be93 into releases/m154 Jun 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants