Searching for csproj, fsproj that uses Microsoft.Net.Sdk.Web #10704
Conversation
…-tasks into users/nijoy/dotnetcorecliv2_improve_webproject_detection
|
Add UTs for this change |
|
Can you make sure that the assumption about |
…-tasks into users/nijoy/dotnetcorecliv2_improve_webproject_detection
Do verify this before you merge the PR. As when we devised this logic, we only thought and verified it for csproj files. Verification for |
Yeah, this is verified for csproj and fsproj. For visual basic i think it's supported from .net core 3, will check before merging |
In case of vbProj, if it is only valid for .Net Core 3.0 and above, then we should not use this logic for vbproj. 3.0 will be RC in July and GA in September, till then its under preview. |
…n' of https://github.com/Microsoft/azure-pipelines-tasks into users/nijoy/dotnetcorecliv2_improve_webproject_detection
Tasks/DotNetCoreCLIV2/Strings/resources.resjson/en-US/resources.resjson
Outdated
Show resolved
Hide resolved
…n' of https://github.com/Microsoft/azure-pipelines-tasks into users/nijoy/dotnetcorecliv2_improve_webproject_detection
issacnitin
changed the title
| @@ -312,6 +312,19 @@ describe('DotNetCoreExe Suite', function () { | |||
| done(); | |||
| }); | |||
|
|
|||
|
|
|||
| it('publish works with publishWebProjects option if .csproj have Microsoft.Net.Sdk.Web', (done: MochaDone) => { | |||
| process.env["__projects__"] = "havesdk*/*.csproj;"; | |||
There was a problem hiding this comment.
how is this test testing your new feature
There was a problem hiding this comment.
We are mocking inputfile argument and defining a mapping for the argument, then we're mocking the output of that definition as well.
* Searching for csproj, vbproj, fsproj using sdk Microsoft.Net.Sdk.Web * Updating package.json * Updating error message * Review comments * Review comments * Try-catch * Iteratively find and check for file encodings * Review comments * Supporting only utf encodings * L0 * Adding semicolons * Removing vbproj * Comments * Updating error message * Updating error message
* Searching for csproj, vbproj, fsproj using sdk Microsoft.Net.Sdk.Web * Updating package.json * Updating error message * Review comments * Review comments * Try-catch * Iteratively find and check for file encodings * Review comments * Supporting only utf encodings * L0 * Adding semicolons * Removing vbproj * Comments * Updating error message * Updating error message
….Sdk.Web (#10704) (#10775) * Searching for csproj, fsproj that uses Microsoft.Net.Sdk.Web (#10704) * Searching for csproj, vbproj, fsproj using sdk Microsoft.Net.Sdk.Web * Updating package.json * Updating error message * Review comments * Review comments * Try-catch * Iteratively find and check for file encodings * Review comments * Supporting only utf encodings * L0 * Adding semicolons * Removing vbproj * Comments * Updating error message * Updating error message * Updating L0 for DotNetCoreCLIV2 task (#10773) * Updating L0 * Removing unnecessary imports * Review comments
…soft.Net.Sdk.Web (#10776) * Searching for csproj, fsproj that uses Microsoft.Net.Sdk.Web (#10704) * Searching for csproj, vbproj, fsproj using sdk Microsoft.Net.Sdk.Web * Updating package.json * Updating error message * Review comments * Review comments * Try-catch * Iteratively find and check for file encodings * Review comments * Supporting only utf encodings * L0 * Adding semicolons * Removing vbproj * Comments * Updating error message * Updating error message * Updating task version * Updating L0 for DotNetCoreCLIV2 task (#10773) * Updating L0 * Removing unnecessary imports * Review comments
No description provided.