Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Identify the root (desktop) element by UIA class name, not runtime ID #1048

Merged
merged 2 commits into from
Sep 5, 2024

Conversation

codeofdusk
Copy link
Contributor

Details

On Windows 11 24H2, the runtime ID of the desktop element changed from [2A,10010] to [2A,1000C], causing live inspect in Accessibility Insights for Windows to break. This PR switches to identifying the desktop element by its UIA class name, which has been stable across all supported Windows versions.

Motivation

Addresses microsoft/accessibility-insights-windows#1837.

Pull request checklist

@codeofdusk codeofdusk requested a review from a team as a code owner September 5, 2024 02:30
Copy link
Contributor

@madalynrose madalynrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codeofdusk codeofdusk merged commit a4c1ba2 into microsoft:main Sep 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants