fix: Downgrade SiblingUniqueAndFocusable to NeedsReview for Win32 apps #1047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madalynrose
approved these changes
Sep 9, 2024
codeofdusk
changed the title
codeofdusk
force-pushed
the
sibling-unique-native-only
branch
2 times, most recently
from
068411e to
803105c
Compare
Due to a large number of false positives (and given the fact that Win32 applications don't support UIA natively), this commit downgrades `SiblingUniqueAndFocusable` to `NeedsReview` in Win32 applications. Addresses microsoft#1046. Supersedes microsoft#1038. Addresses microsoft/accessibility-insights-windows#1838.
codeofdusk
force-pushed
the
sibling-unique-native-only
branch
from
803105c to
1463b67
Compare
codeofdusk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Due to a large number of false positives (and given the fact that Win32 applications don't support UIA natively), downgrade
SiblingUniqueAndFocusabletoNeedsReviewin Win32 applications.Motivation
Addresses #1046. Supersedes #1038. Addresses microsoft/accessibility-insights-windows#1838.
Pull request checklist