Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] False positive with Wizards (property sheet) #1046

Closed
v-chojas opened this issue Aug 26, 2024 · 1 comment
Closed

[BUG] False positive with Wizards (property sheet) #1046

v-chojas opened this issue Aug 26, 2024 · 1 comment
Assignees
@codeofdusk
Labels
status: resolved This issue has been merged into main.

Comments

@v-chojas
Copy link

Describe the bug

Wizards are implemented as property sheets with one tab per page and that appears to cause a false positive.

To Reproduce
Steps to reproduce the behavior:

  1. Open Device Manager
  2. Select Computer and choose Action -> Add legacy hardware
  3. Click Next
  4. Hover over this window with Accessibility Insights and click Test icon

Expected behavior

No false positives.

Actual behavior

"Focusable sibling elements must not have the same Name and LocalizedControlType" error on each page of the wizard, highlighting the nonexistent "tabs" which are by no means focusable.

Screenshots or .GIF

addhw

Desktop (please complete the following information):

  • OS: Windows Server 2022 (update version 10.20348.2655), Windows 11 24H2 (update version 10.26100.1457)
  • Accessibility Insights for Windows Version: 1.1.2703.1
  • Target Application: Add Hardware wizard
  • Target Application Version: see Windows version

Additional context

I have a minimal repro app I can provide if necessary, but since I could also reproduce this on Windows' own Add Hardware wizard, that one can be used for an easy test.
@microsoft-github-policy-service microsoft-github-policy-service bot added the status: new This issue is new and requires triage by DRI. label Aug 26, 2024
@JGibson2019 JGibson2019 added status: needs investigation This issue requires investigation (PM, Design, or SWE) by the Accessibility Insights team. and removed status: new This issue is new and requires triage by DRI. labels Aug 27, 2024
@JGibson2019 JGibson2019 moved this from Needs triage to Tabled in Accessibility Insights Aug 27, 2024
@codeofdusk codeofdusk mentioned this issue Sep 3, 2024
Merged
1 task
codeofdusk added a commit that referenced this issue Sep 14, 2024
@codeofdusk
fix: Downgrade SiblingUniqueAndFocusable to NeedsReview for Win32 apps
cd88bf9 
Due to a large number of false positives (and given the fact that Win32 applications don't support UIA natively), this commit downgrades `SiblingUniqueAndFocusable` to `NeedsReview` in Win32 applications.

Addresses #1046. Supersedes #1038. Addresses microsoft/accessibility-insights-windows#1838.
@codeofdusk codeofdusk self-assigned this Sep 16, 2024
@codeofdusk codeofdusk added status: resolved This issue has been merged into main. and removed status: needs investigation This issue requires investigation (PM, Design, or SWE) by the Accessibility Insights team. labels Sep 16, 2024
@codeofdusk codeofdusk mentioned this issue Sep 16, 2024
Closed
@codeofdusk
Copy link
Contributor

Resolved in latest release (this rule has been downgraded to NeedsReview) in Win32 applications.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codeofdusk codeofdusk

Labels
status: resolved This issue has been merged into main.
Projects
Accessibility Insights
Archived in project
Milestone
No milestone
Development

No branches or pull requests
7 participants
@codeofdusk @JGibson2019 @v-chojas and others