fix: remove NaN from fastpass report by removing concatenation in OutcomeSummaryBar #857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haonliu
previously approved these changes
Jun 25, 2019
karanbirsingh
changed the title
karanbirsingh
changed the title
waabid
approved these changes
Jun 25, 2019
Shobhit1
approved these changes
Jun 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
If the
countSuffixproperty isn't provided (like in the FastPass report), concatenating a number with anundefinedcountSuffixresults inNaN, leading to issue #852. This PR removes the concatenation and instead lets React render the undefined (no-op) value.Pull request checklist
yarn test)<rootDir>/test-results/unit/coverageyarn precheckin)