fix: remove NaN from fastpass report by removing concatenation in Out…

…comeSummaryBar (#857)
microsoft · Jun 25, 2019 · 3729799 · 3729799
1 parent b4f7b2d
commit 3729799
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 10 deletions.
diff --git a/src/DetailsView/reports/components/outcome-summary-bar.tsx b/src/DetailsView/reports/components/outcome-summary-bar.tsx
@@ -26,7 +26,8 @@ export const OutcomeSummaryBar = NamedSFC<OutcomeSummaryBarProps>('OutcomeSummar
                 return (
                     <div key={outcomeType} style={{ flexGrow: count }}>
                         <span className={kebabCase(outcomeType)}>
-                            {outcomeIcon} {count + countSuffix} <span className="outcome-past-tense">{text}</span>
+                            {outcomeIcon} {count}
+                            {countSuffix} <span className="outcome-past-tense">{text}</span>
                         </span>
                     </div>
                 );

diff --git a/...unit/tests/DetailsView/reports/components/__snapshots__/outcome-summary-bar.test.tsx.snap b/...unit/tests/DetailsView/reports/components/__snapshots__/outcome-summary-bar.test.tsx.snap
@@ -16,7 +16,7 @@ exports[`OutcomeSummaryBar render inverted badges 1`] = `
     >
       <CheckIconInverted />
        
-      NaN
+      42
        
       <span
         className="outcome-past-tense"
@@ -37,7 +37,7 @@ exports[`OutcomeSummaryBar render inverted badges 1`] = `
     >
       <CrossIconInverted />
        
-      NaN
+      13
        
       <span
         className="outcome-past-tense"
@@ -58,7 +58,7 @@ exports[`OutcomeSummaryBar render inverted badges 1`] = `
     >
       <CircleIcon />
        
-      NaN
+      7
        
       <span
         className="outcome-past-tense"
@@ -86,7 +86,8 @@ exports[`OutcomeSummaryBar show by percentage 1`] = `
     >
       <CheckIcon />
        
-      42%
+      42
+      %
        
       <span
         className="outcome-past-tense"
@@ -107,7 +108,8 @@ exports[`OutcomeSummaryBar show by percentage 1`] = `
     >
       <CrossIcon />
        
-      13%
+      13
+      %
        
       <span
         className="outcome-past-tense"
@@ -128,7 +130,8 @@ exports[`OutcomeSummaryBar show by percentage 1`] = `
     >
       <CircleIcon />
        
-      7%
+      7
+      %
        
       <span
         className="outcome-past-tense"
@@ -156,7 +159,7 @@ exports[`OutcomeSummaryBar show by percentage 2`] = `
     >
       <CheckIcon />
        
-      NaN
+      42
        
       <span
         className="outcome-past-tense"
@@ -177,7 +180,7 @@ exports[`OutcomeSummaryBar show by percentage 2`] = `
     >
       <CrossIcon />
        
-      NaN
+      13
        
       <span
         className="outcome-past-tense"
@@ -198,7 +201,7 @@ exports[`OutcomeSummaryBar show by percentage 2`] = `
     >
       <CircleIcon />
        
-      NaN
+      7
        
       <span
         className="outcome-past-tense"