Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(null): make cardSelectionMessageCreator optional for all result sections #5951

Merged
merged 5 commits into from
Aug 25, 2022
Merged

chore(null): make cardSelectionMessageCreator optional for all result sections #5951

merged 5 commits into from
Aug 25, 2022

Conversation

madalynrose
Copy link
Contributor

Details

This PR is the second part of an effort to add src/common/components to tsconfig.strictNullChecks.json

I traced cardSelectionMessageCreator props down through FailureInstancesSection to carry its optional nature into child components.

Motivation

Works towards #2869

Context

Continues work from #5946

Pull request checklist

  • Addresses an existing issue: Codebase should use strict null checks #2869
  • Ran yarn null:autoadd
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [N/A] (UI changes only) Added screenshots/GIFs to description above
  • [N/A] (UI changes only) Verified usability with NVDA/JAWS

@madalynrose madalynrose requested a review from a team as a code owner August 22, 2022 17:57
pownkel
pownkel approved these changes Aug 24, 2022
View reviewed changes
Copy link
Contributor

@pownkel pownkel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@madalynrose madalynrose merged commit 65d2a4b into microsoft:main Aug 25, 2022
@madalynrose madalynrose deleted the null-checks-common-components-csmc branch August 25, 2022 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pownkel pownkel pownkel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@madalynrose @pownkel