Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(null): address straightforward null check errors for src/common/components #5946

Merged

Conversation

madalynrose
Copy link
Contributor

Details

This PR is the first part of an effort to add the entire src/common/components/ directory to tsconfig.strictNullChecks.json. This addresses the straightforward null check fixes needed to add that directory.

The one slightly tricky change here removes fixInstructionProcessor from props for RulesWithInstances, as it is already present in deps.

Motivation

Works towards #2869

Context

A followup PR will address the one outstanding strict null failure, makingcardSelectionMessageCreator optional for all result sections.

Pull request checklist

  • Addresses an existing issue: Codebase should use strict null checks #2869
  • Ran yarn null:autoadd
  • Ran yarn fastpass
  • Added/updated relevant unit test(s) (and ran yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • PR title AND final merge commit title both start with a semantic tag (fix:, chore:, feat(feature-name):, refactor:). See CONTRIBUTING.md.
  • [N/A] (UI changes only) Added screenshots/GIFs to description above
  • [N/A] (UI changes only) Verified usability with NVDA/JAWS

@madalynrose madalynrose requested a review from a team as a code owner August 22, 2022 14:59
@dbjorge
Copy link
Contributor

dbjorge commented Aug 22, 2022

LGTM, thanks Madalyn!

@madalynrose madalynrose merged commit 53a178a into microsoft:main Aug 22, 2022
@madalynrose madalynrose deleted the null-checks-common-components-simple branch August 22, 2022 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants