-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mvp-ado-extension-behavior): Disable e2e/ Remove the GH repo token from the task inputs #844
Conversation
Accessibility Insights Action
Failed instances
This scan used axe-core 4.3.2 with Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.75 Safari/537.36. |
Codecov Report
@@ Coverage Diff @@
## main #844 +/- ##
=======================================
Coverage 86.83% 86.83%
=======================================
Files 39 39
Lines 790 790
Branches 85 85
=======================================
Hits 686 686
Misses 104 104 Continue to review full report at Codecov.
|
@@ -52,13 +52,6 @@ | |||
"required": false, | |||
"helpMarkDown": "Path to Chrome executable." | |||
}, | |||
{ | |||
"name": "repoToken", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also remove the getToken()
from ado-task-config.ts
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not necessarily, it won't hurt for now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM; minor comment inline
Details
This PR disables e2e and removes the GitHub repo token from the task inputs.
Motivation
Get the pipeline to work till 'azure-pipeline-task-lib' team reply to the webpack issue.
Remove the GH repo token from user interface till we add its functionality.
Context
Pull request checklist
yarn test
)<rootDir>/test-results/unit/coverage
yarn precheckin
)Accessibility Checks (pull_request)
check should fail. All other checks should pass.