Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mvp-ado-extension-behavior): Disable e2e/ Remove the GH repo token from the task inputs #844

Merged
merged 1 commit into from
Sep 14, 2021

Conversation

AhmedAbdoOrtiga
Copy link
Contributor

@AhmedAbdoOrtiga AhmedAbdoOrtiga commented Sep 14, 2021

Details

This PR disables e2e and removes the GitHub repo token from the task inputs.

Motivation

Get the pipeline to work till 'azure-pipeline-task-lib' team reply to the webpack issue.

Remove the GH repo token from user interface till we add its functionality.

Context

Pull request checklist

  • Addresses an existing issue: Fixes #0000
  • Added relevant unit test for your changes. (yarn test)
  • Verified code coverage for the changes made. Check coverage report at: <rootDir>/test-results/unit/coverage
  • Ran precheckin (yarn precheckin)
  • (after PR created) The Accessibility Checks (pull_request) check should fail. All other checks should pass.

@AhmedAbdoOrtiga AhmedAbdoOrtiga requested a review from a team as a code owner September 14, 2021 21:38
@github-actions
Copy link
Contributor

Accessibility Insights Accessibility Insights Action

  • URLs: 1 URL(s) failed, 3 URL(s) passed, and 0 were not scannable
  • Rules: 6 check(s) failed, 11 check(s) passed, and 37 were not applicable
  • Download the Accessibility Insights artifact to view the detailed results of these checks

Failed instances

  • 3 × label: Ensures every form element has a label
  • 1 × html-has-lang: Ensures every HTML document has a lang attribute
  • 1 × image-alt: Ensures <img> elements have alternate text or a role of none or presentation
  • 1 × input-image-alt: Ensures <input type="image"> elements have alternate text

This scan used axe-core 4.3.2 with Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/86.0.4240.75 Safari/537.36.

@codecov-commenter
Copy link

Codecov Report

Merging #844 (37be6a6) into main (5254130) will not change coverage.
The diff coverage is n/a.

❗ Current head 37be6a6 differs from pull request most recent head 3b60c76. Consider uploading reports for the commit 3b60c76 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main     #844   +/-   ##
=======================================
  Coverage   86.83%   86.83%           
=======================================
  Files          39       39           
  Lines         790      790           
  Branches       85       85           
=======================================
  Hits          686      686           
  Misses        104      104           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5254130...3b60c76. Read the comment docs.

@@ -52,13 +52,6 @@
"required": false,
"helpMarkDown": "Path to Chrome executable."
},
{
"name": "repoToken",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also remove the getToken() from ado-task-config.ts?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not necessarily, it won't hurt for now

Copy link
Contributor

@lisli1 lisli1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; minor comment inline

@AhmedAbdoOrtiga AhmedAbdoOrtiga merged commit e0c1f45 into main Sep 14, 2021
@AhmedAbdoOrtiga AhmedAbdoOrtiga deleted the ahmohame/disable-e2e branch September 14, 2021 22:17
@lisli1 lisli1 mentioned this pull request Sep 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants